This repository was archived by the owner on Nov 6, 2023. It is now read-only.
[New ruleset] PHPDoc #3184
Merged
[New ruleset] PHPDoc #3184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
disabled because expired cert; [I've asked](https://twitter.com/rugkme/status/664158508808581121) what PhpDoc wants to do about this
Contributor
|
@jsha is wary of adding default_off rules that will only cause bloat, but, given their answer on Twitter, let's give this one a bit of time. |
Contributor
Author
|
IMO this does not cause bloat because some users (like I would) enable the rule and just add an exception to the rule. But let's not discuss this now, because you're right we can what now. |
Contributor
|
Hm, okay, looks like they replaced their self-signed cert with another self-signed one, so that didn't help all that much from the point of view of https-e. |
Contributor
Author
Contributor
|
Bleh, I hate adding default_off rules, though you claim you'll use it ... |
Contributor
Author
|
Well... I still hope they will switch to a CA soon. |
Contributor
Author
|
Finally they announced they'll do. 😃 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
disabled because expired cert; I've asked what PhpDoc wants to do about this.