Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Conversation

@rugk
Copy link
Contributor

@rugk rugk commented Dec 18, 2015

Continuing #3184

Preparing ruleset for the change of phpdoc to @letsencrypt they announced. You can merge this once they have switched.

@J0WI
Copy link
Contributor

J0WI commented Dec 18, 2015

Hopefully they will also fix their subdomains:

  • demo
  • manual
  • pear

@rugk
Copy link
Contributor Author

rugk commented Dec 18, 2015

Yes, I reminded them.

Just acting on the assumption that they will fix it properly.
@rugk
Copy link
Contributor Author

rugk commented Dec 18, 2015

BTW interesting that Travis CI does not fail. Should not it fail currently as the domain is using self-signed certs?

@rugk rugk changed the title [Phpdoc] Activate ruleset [Phpdoc] Activate ruleset [DNM] Dec 18, 2015
@fuglede
Copy link
Contributor

fuglede commented Dec 20, 2015

@rugk: The Travis tests don't do any testing against the actual web servers; it only checks local stuff. (#3107 is relevant here.)

@rugk
Copy link
Contributor Author

rugk commented Dec 20, 2015

Ah okay. Thanks for the information.

@semenko
Copy link
Contributor

semenko commented Jan 18, 2016

Closing this given their continued breakage & self-signing. Please reopen if they get a real set of certs.

@semenko semenko closed this Jan 18, 2016
@rugk
Copy link
Contributor Author

rugk commented Feb 26, 2016

I've got it. They now use real certs.
Can you please reopen this PR? I've already adjusted the ruleset.

@fuglede fuglede reopened this Feb 26, 2016
fuglede added a commit that referenced this pull request Feb 26, 2016
[Phpdoc] Activate ruleset [DNM]
@fuglede fuglede merged commit f2abcc9 into EFForg:master Feb 26, 2016
@rugk rugk deleted the patch-phpdoc branch February 26, 2016 21:23
@rugk
Copy link
Contributor Author

rugk commented Feb 26, 2016

Nice, this was fast.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants