Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Conversation

@fuglede
Copy link
Contributor

@fuglede fuglede commented Jan 24, 2015

Included with default_off as the entire site works, except for its contact forms. However, if you ever visit the site, it's probably to complain about something, so the contact forms are essential.

@jsha
Copy link
Member

jsha commented Feb 15, 2015

I'd prefer not to merge new rulesets that are default_off from the beginning. I think that is more useful for rules that worked once, but stopped working, in order to preserve some history and make it easy to fix them.

@jsha jsha closed this Feb 15, 2015
@fuglede
Copy link
Contributor Author

fuglede commented Feb 16, 2015

@jsha: Fair enough; I figured this one might be useful to users who actively activate rules as most of the site works fine, and that moreover it might save some time if someone else decides to write a rule for it later on (twice I've found myself beginning to write a rule, only to realize that it already exists).

@fuglede fuglede deleted the rejsekort.dk-rules branch June 24, 2015 14:58
@fuglede fuglede mentioned this pull request Aug 27, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants