Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses issues with the NuGet pack operation and prerelease workflow configuration. The changes update how the generator DLL is included in the NuGet package, remove a prerelease flag from the release workflow, and bump the prerelease package version.
Changes:
- Modified the pack configuration to reference the Generator DLL from its bin directory instead of the output path
- Removed the
include-prerelease: Trueflag from the .NET setup in the release workflow - Bumped the prerelease package version from 4.0.0 to 5.0.0
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/EntityFrameworkCore.Projectables.Abstractions/EntityFrameworkCore.Projectables.Abstractions.csproj | Changes the DLL inclusion path from $(OutputPath) to an explicit relative path to fix pack operation |
| .github/workflows/release.yml | Removes include-prerelease flag from .NET 10.0.x setup |
| .github/workflows/build.yml | Bumps prerelease version from 4.0.0-pre to 5.0.0-pre |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <ItemGroup> | ||
| <!-- Package the generator in the analyzer directory of the nuget package --> | ||
| <None Include="$(OutputPath)\EntityFrameworkCore.Projectables.Generator.dll" Pack="true" PackagePath="analyzers/dotnet/cs" Visible="false" /> | ||
| <None Include="..\EntityFrameworkCore.Projectables.Generator\bin\$(Configuration)\netstandard2.0\EntityFrameworkCore.Projectables.Generator.dll" Pack="true" PackagePath="analyzers/dotnet/cs" Visible="false" /> |
There was a problem hiding this comment.
The change from using $(OutputPath) to an explicit relative path may introduce build order dependencies. The pack operation will now fail if the EntityFrameworkCore.Projectables.Generator project has not been built first in the correct configuration. While this approach can work, it relies on MSBuild building projects in the correct order. Consider verifying that the solution build order ensures the Generator project is built before this project is packed. Alternatively, you could use a build target that explicitly depends on the Generator project's build output to ensure proper sequencing.
Member
Author
|
@koenbeuk after merging this, I tried to publish a v5.0.1 with the same changelog as v5.0.0 plus a not about the fact that it's the same as v5.0.1, but got a nuget api key issue (everything work except this), see I may need your help to make the release |
github-merge-queue bot
pushed a commit
to DFE-Digital/teaching-record-system
that referenced
this pull request
Feb 24, 2026
Updated [EntityFrameworkCore.Projectables](https://github.com/koenbeuk/EntityFrameworkCore.Projectables) from 4.0.0 to 5.0.2. <details> <summary>Release notes</summary> _Sourced from [EntityFrameworkCore.Projectables's releases](https://github.com/koenbeuk/EntityFrameworkCore.Projectables/releases)._ ## 5.0.2 ## What's Changed * Fix pack and prerelease workflow by @PhenX in EFNext/EntityFrameworkCore.Projectables#145 * Add support for dictionary index initializers in expressions by @PhenX in EFNext/EntityFrameworkCore.Projectables#146 **Full Changelog**: EFNext/EntityFrameworkCore.Projectables@v5.0.0...v5.0.2 ## 5.0.0 ## What's Changed * Handle global query filters (Fixes #81) by @PhenX in EFNext/EntityFrameworkCore.Projectables#130 * don't rewrite the query root when attempting to track the results by @hahn-kev in EFNext/EntityFrameworkCore.Projectables#132 * Add support for declaration patterns in switch expressions by convert… by @7645re in EFNext/EntityFrameworkCore.Projectables#136 * Add support for .NET 10 by @PhenX in EFNext/EntityFrameworkCore.Projectables#142 ## New Contributors * @hahn-kev made their first contribution in EFNext/EntityFrameworkCore.Projectables#132 * @7645re made their first contribution in EFNext/EntityFrameworkCore.Projectables#136 **Full Changelog**: EFNext/EntityFrameworkCore.Projectables@v4.0.0...v5.0.0 ## 4.1.0-preview.1 ## What's Changed * Handle global query filters (Fixes #81) by @PhenX in EFNext/EntityFrameworkCore.Projectables#130 * don't rewrite the query root when attempting to track the results by @hahn-kev in EFNext/EntityFrameworkCore.Projectables#132 * Add support for declaration patterns in switch expressions by convert… by @7645re in EFNext/EntityFrameworkCore.Projectables#136 ## New Contributors * @hahn-kev made their first contribution in EFNext/EntityFrameworkCore.Projectables#132 * @7645re made their first contribution in EFNext/EntityFrameworkCore.Projectables#136 **Full Changelog**: EFNext/EntityFrameworkCore.Projectables@v4.0.0...v4.1.0 Commits viewable in [compare view](EFNext/EntityFrameworkCore.Projectables@v4.0.0...v5.0.2). </details> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: James Gunn <james@gunn.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.