Skip to content

Fix pack and prerelease workflow #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PhenX merged 1 commit into from
Jan 10, 2026
+2 −3
Merged

Fix pack and prerelease workflow #145

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ jobs:
dotnet-version: 10.0.x
- name: Pack
run: |
dotnet pack -v normal -c Debug --include-symbols --include-source -p:PackageVersion=4.0.0-pre-$GITHUB_RUN_ID -o nupkg
dotnet pack -v normal -c Debug --include-symbols --include-source -p:PackageVersion=5.0.0-pre-$GITHUB_RUN_ID -o nupkg
- name: Push to GitHub Feed
run: |
for f in ./nupkg/*.nupkg
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ jobs:
uses: actions/setup-dotnet@v5
with:
dotnet-version: 10.0.x
include-prerelease: True
- name: Create Release NuGet package
run: |
arrTag=(${GITHUB_REF//\// })
Expand Down
2 changes: 1 addition & 1 deletion ...meworkCore.Projectables.Abstractions/EntityFrameworkCore.Projectables.Abstractions.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@

<ItemGroup>
<!-- Package the generator in the analyzer directory of the nuget package -->
<None Include="$(OutputPath)\EntityFrameworkCore.Projectables.Generator.dll" Pack="true" PackagePath="analyzers/dotnet/cs" Visible="false" />
<None Include="..\EntityFrameworkCore.Projectables.Generator\bin\$(Configuration)\netstandard2.0\EntityFrameworkCore.Projectables.Generator.dll" Pack="true" PackagePath="analyzers/dotnet/cs" Visible="false" />
Copy link

Copilot AI Jan 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change from using $(OutputPath) to an explicit relative path may introduce build order dependencies. The pack operation will now fail if the EntityFrameworkCore.Projectables.Generator project has not been built first in the correct configuration. While this approach can work, it relies on MSBuild building projects in the correct order. Consider verifying that the solution build order ensures the Generator project is built before this project is packed. Alternatively, you could use a build target that explicitly depends on the Generator project's build output to ensure proper sequencing.

Copilot uses AI. Check for mistakes.
</ItemGroup>

<ItemGroup>
Expand Down