Skip to content

Applied fix of 2316, but exposed isssue 2318#2319

Merged
jajhall merged 3 commits intolatestfrom
fix-2316
May 6, 2025
Merged

Applied fix of 2316, but exposed isssue 2318#2319
jajhall merged 3 commits intolatestfrom
fix-2316

Conversation

@jajhall
Copy link
Copy Markdown
Member

@jajhall jajhall commented May 5, 2025

No description provided.

@jajhall jajhall mentioned this pull request May 5, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented May 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.30%. Comparing base (b58fb8e) to head (2727c6b).
Report is 6 commits behind head on latest.

Additional details and impacted files
@@            Coverage Diff             @@
##           latest    #2319      +/-   ##
==========================================
- Coverage   79.32%   79.30%   -0.02%     
==========================================
  Files         345      345              
  Lines       84413    84413              
==========================================
- Hits        66959    66947      -12     
- Misses      17454    17466      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jajhall jajhall requested a review from galabovaa May 5, 2025 20:05
@jajhall
Copy link
Copy Markdown
Member Author

jajhall commented May 5, 2025

@galabovaa , the valgrind failures appear to be just due to calling settings_clear(settings); before timers_clear(w->settings->nLogLevel, timers);, something that's fixed in #2251

Copy link
Copy Markdown
Contributor

@galabovaa galabovaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@jajhall jajhall merged commit c7e48d5 into latest May 6, 2025
303 of 306 checks passed
@jajhall jajhall deleted the fix-2316 branch May 6, 2025 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants