Skip to content

change glc -> ocn export fields to be glc->rof#100

Merged
Katetc merged 27 commits intoESCOMP:cismwrap_to_rof_branchfrom
mvertens:feature/cism2mosart_cesm
Jun 28, 2024
Merged

change glc -> ocn export fields to be glc->rof#100
Katetc merged 27 commits intoESCOMP:cismwrap_to_rof_branchfrom
mvertens:feature/cism2mosart_cesm

Conversation

@mvertens
Copy link
Contributor

This PR does the following

mvertens and others added 25 commits August 30, 2023 11:04
Change CISM_USE_ICESHEET to GLC_USE_ICESHEET
update of noresm cism_wrapper to cismwrap_2_1_99
@mvertens
Copy link
Contributor Author

@Katetc - not sure how we want to proceed with this - including the review.

@mvertens mvertens marked this pull request as ready for review June 18, 2024 10:12
@jedwards4b
Copy link
Contributor

@Katetc Do you want to review this - I need it for cesm3_0_alpha02a.

@Katetc Katetc self-requested a review June 26, 2024 16:25
@Katetc
Copy link
Contributor

Katetc commented Jun 26, 2024

@Katetc Do you want to review this - I need it for cesm3_0_alpha02a.

Yes, I would like to. Thanks!

Copy link
Contributor

@Katetc Katetc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we could put the surface fields outside of the no-evolve check, then I would be very happy merging this PR. If not, I'd like to chat about that a bit. Thanks Mariana!

call fldlist_add(fldsToGlc_num, fldsToGlc, field_in_tsrf)
call fldlist_add(fldsToGlc_num, fldsToGlc, field_in_qice)
call fldlist_add(fldsToGlc_num, fldsToGlc, field_in_so_t_depth, ungridded_lbound=1, ungridded_ubound=nlev_import)
call fldlist_add(fldsToGlc_num, fldsToGlc, field_in_so_s_depth, ungridded_lbound=1, ungridded_ubound=nlev_import)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I think it would make a lot of sense for these ocean-depth fields to be inside of an only "cism evolving" check. But the 2D temperature and surface mass balance should be advertised for both cases.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Katetc Katetc changed the base branch from master to cismwrap_to_rof_branch June 28, 2024 22:40
@Katetc Katetc merged commit 2263d3c into ESCOMP:cismwrap_to_rof_branch Jun 28, 2024
@Katetc
Copy link
Contributor

Katetc commented Jun 28, 2024

Merged to a temporary branch where I can work out the external tags and write up the ChangeLog before merging to Main. Thanks Mariana!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants