Skip to content

mosart1.1.09: Put instantaneous and non-inst. fields on separate history files #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
slevis-lmwg merged 24 commits into from
Jul 4, 2025
Merged

mosart1.1.09: Put instantaneous and non-inst. fields on separate history files #117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
8ad9923
Put instantaneous & non-inst hist fields in separate files (not tested)
slevis-lmwg May 23, 2025
ef55d37
Add some of the missing variable declarations
slevis-lmwg Jun 6, 2025
d28913f
Various corrections for the build to finish successfully
slevis-lmwg Jun 18, 2025
c4652a5
Change an inactive 'A' history field to active 'I' for test to PASS
slevis-lmwg Jun 18, 2025
9ff10fb
Reorder a few lines as in the equivalent clm code to move past failure
slevis-lmwg Jun 19, 2025
22d52df
Simplify itemp2d to itemp as done in clm's histFileMod.F90
slevis-lmwg Jun 24, 2025
08bbb00
Add two lines that I missed from my clm version
slevis-lmwg Jun 24, 2025
d453dae
Corrections to get past errors in ERP test
slevis-lmwg Jun 24, 2025
4626d03
Reorder more lines as in the equivalent clm code to move past failure
slevis-lmwg Jun 25, 2025
119c0a6
Revisions to config_archive.xml as recommended in code review
slevis-lmwg Jun 26, 2025
c98bc85
Revisions to mosart_histfile.F90 as recommended in code review
slevis-lmwg Jun 26, 2025
9c02d6a
Merge remote-tracking branch 'origin/master' into sep_hXi_hXa_tapes_i…
slevis-lmwg Jun 27, 2025
6fe0dbd
Draft ChangeLog
slevis-lmwg Jun 28, 2025
964ba05
Minor update to comments for consistency with clm
slevis-lmwg Jun 30, 2025
6c02c3b
2nd minor comment update for consistency with clm
slevis-lmwg Jun 30, 2025
4da916f
Improved error message to include file number
slevis-lmwg Jun 30, 2025
a69db38
Add test for the new "e" file type for DART
slevis-lmwg Jul 3, 2025
55df48f
Remove confusing comment
slevis-lmwg Jul 3, 2025
9166556
Replace previously removed comment with a clearer comment
slevis-lmwg Jul 3, 2025
e523cf8
Change dim. ntapes_by_max_split_files to ntapes_multiply_by_max_split…
slevis-lmwg Jul 3, 2025
755bb99
Correction motivated by corresponding clm commit a7fd23ca20e17a6abfc4…
slevis-lmwg Jul 3, 2025
7f6c882
Add comment explaining the need for at least one 'I' field in MOSART
slevis-lmwg Jul 3, 2025
b66043d
Replace call endrun with call shr_sys_abort for code to work
slevis-lmwg Jul 3, 2025
d9b2f9d
Update ChangeLog
slevis-lmwg Jul 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions cime_config/config_archive.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@

<comp_archive_spec compname="mosart" compclass="rof">
<rest_file_extension>r</rest_file_extension>
<rest_file_extension>rh\d*</rest_file_extension>
<rest_file_extension>rh\da</rest_file_extension>
<rest_file_extension>rh\di</rest_file_extension>
<hist_file_extension>h\d*.*\.nc$</hist_file_extension>
<hist_file_extension>e</hist_file_extension>
<rest_history_varname>locfnh</rest_history_varname>
Expand All @@ -12,11 +13,15 @@
</rpointer>
<test_file_names>
<tfile disposition="copy">rpointer.rof</tfile>
<tfile disposition="copy">rpointer.rof_9999</tfile>
<tfile disposition="copy">rpointer.rof_9999.1976-01-01-00000</tfile>
<tfile disposition="copy">casename.mosart.r.1976-01-01-00000.nc</tfile>
<tfile disposition="copy">casename.mosart.rh4.1976-01-01-00000.nc</tfile>
<tfile disposition="move">casename.mosart.h0.1976-01-01-00000.nc</tfile>
<tfile disposition="ignore">casename.mosart.h0.1976-01-01-00000.nc.base</tfile>
<tfile disposition="copy">casename.mosart.rh4a.1976-01-01-00000.nc</tfile>
<tfile disposition="copy">casename.mosart.rh4i.1976-01-01-00000.nc</tfile>
<tfile disposition="move">casename.mosart.h0a.1976-01-01-00000.nc</tfile>
<tfile disposition="move">casename.mosart.h0i.1976-01-01-00000.nc</tfile>
<tfile disposition="move">casename.mosart.e.1976-01-01-00000.nc</tfile>
<tfile disposition="ignore">casename.mosart.h0a.1976-01-01-00000.nc.base</tfile>
<tfile disposition="ignore">casename.mosart.h0i.1976-01-01-00000.nc.base</tfile>
</test_file_names>
</comp_archive_spec>

Expand Down
22 changes: 22 additions & 0 deletions docs/ChangeLog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,25 @@
<hr>
# Tag name: mosart1.1.09
### Originator(s): slevis
### Date: Jul 03, 2025
### One-line Summary: Separate instantaneous and non-inst. history files

This is the mosart equivalent of ESCOMP/CTSM#2445.
Also includes the merge of #118, though this DART-related one-line update seems to have been present in master already.

Contributors: Erik Kluzek, Kevin Raeder

Fixes ESCOMP/MOSART#52 Separate instantaneous from non-inst. history tapes
Fixes ESCOMP/MOSART#116 Make st_archive handle output files from future MOSART+DART experiments

Testing: standard testing
izumi ---- OK
derecho -- OK

See https://github.com/ESCOMP/MOSART/pull/117 for more details
See https://github.com/ESCOMP/MOSART/pull/118 for more details
Contributes to https://github.com/ESCOMP/CTSM/pull/2445

<hr>
# Tag name: mosart1.1.08
### Originator(s): samrabin
Expand Down
Loading