Skip to content

mosart1.1.09: Put instantaneous and non-inst. fields on separate history files#117

Merged
slevis-lmwg merged 24 commits intoESCOMP:masterfrom
slevis-lmwg:sep_hXi_hXa_tapes_iss52
Jul 4, 2025
Merged

mosart1.1.09: Put instantaneous and non-inst. fields on separate history files#117
slevis-lmwg merged 24 commits intoESCOMP:masterfrom
slevis-lmwg:sep_hXi_hXa_tapes_iss52

Conversation

@slevis-lmwg
Copy link
Contributor

@slevis-lmwg slevis-lmwg commented May 23, 2025

This is the MOSART equivalent of the work that I did in ESCOMP/CTSM#2445 for the CLM. For MOSART this work started in #69 originally.

Resolves issue #52.

@slevis-lmwg
Copy link
Contributor Author

slevis-lmwg commented May 30, 2025

Testing guidance in this comment:
ESCOMP/CTSM#2445 (comment)

Latest attempt on izumi ./run_sys_tests -s mosart --skip-compare --skip-generate

FAIL ERP_D.f10_f10_mg37.I1850Clm60Sp.izumi_nag.mosart-qgrwlOpts RUN

Made it past earlier errors of no file name in case2run and later no rh files copied to case2run. For the latter, eventually I just needed to submit the test anew. The new error to fix is here:
/scratch/cluster/slevis/ERP_D.f10_f10_mg37.I1850Clm60Sp.izumi_nag.mosart-qgrwlOpts.20250624_175353_ni1nta/run/case2run/cesm.log...

Runtime Error: /fs/cgd/data0/slevis/git/sep_inst_flds_iss1059/cime/../components/mosart/src/riverroute/mosart_histfile.F90, line 1552: Subscript 2 of NCID_HIST (value 3) is out of range (1:2)
/fs/cgd/data0/slevis/git/sep_inst_flds_iss1059/cime/../components/mosart/src/riverroute/mosart_histfile.F90, line 1552: Error occurred in MOSART_HISTFILE:MOSART_HIST_RESTART
/fs/cgd/data0/slevis/git/sep_inst_flds_iss1059/cime/../components/mosart/src/riverroute/mosart_restfile.F90, l

See new attempt with the same test.

@github-project-automation github-project-automation bot moved this to Ready to start (or start again) in CTSM: Upcoming tags Jun 21, 2025
@slevis-lmwg slevis-lmwg moved this from Ready to start (or start again) to In progress - release/externals / MOSART / RTM / mizu etc. tags in CTSM: Upcoming tags Jun 21, 2025
@slevis-lmwg slevis-lmwg changed the title Put instantaneous and non-inst history fields in separate files mosart1.1.09: Put instantaneous and non-inst history fields in separate files Jun 21, 2025
@slevis-lmwg slevis-lmwg changed the title mosart1.1.09: Put instantaneous and non-inst history fields in separate files mosart1.1.09: Put instantaneous and non-inst. fields on separate history files Jun 23, 2025
@slevis-lmwg
Copy link
Contributor Author

slevis-lmwg commented Jun 25, 2025

./run_sys_tests -s mosart --skip-compare --skip-generate

  • on izumi and derecho noting
    FAIL SMS_D_Ld5.f10_f10_mg37.I1850Clm60Sp.derecho_nvhpc.mosart-default SETUP
    that I've cleared before with Jim Edwards.
  • work on Erik's code review in #2445 as it applies to #2445 and here
  • run tests as recommended here: ctsm5.3.062: Put instantaneous and non-inst. fields on separate history files CTSM#2445 (comment)
  • confirmed mosart history output has not changed bitwise by trying this command
    diff /glade/derecho/scratch/slevis/tests_0627-180421de/SMS_Ld5.f10_f10_mg37.I1850Clm60Sp.derecho_intel.mosart-mosartCold.GC.0627-180421de_int/run/SMS_Ld5.f10_f10_mg37.I1850Clm60Sp.derecho_intel.mosart-mosartCold.GC.0627-180421de_int.mosart.h0a.0001-01-06-00000.asc /glade/work/slevis/git/mksurfdata_toolchain/tests_0627-170402de/SMS_Ld5.f10_f10_mg37.I1850Clm60Sp.derecho_intel.mosart-mosartCold.GC.0627-170402de_int/run/SMS_Ld5.f10_f10_mg37.I1850Clm60Sp.derecho_intel.mosart-mosartCold.GC.0627-170402de_int.mosart.h0.0001-01-06-00000.asc
    and
    diff /fs/cgd/data0/slevis/git/sep_inst_flds_iss1059/tests_0627-180718iz/SMS_D_Ld5.f10_f10_mg37.I1850Clm60Sp.izumi_nag.mosart-default.GC.0627-180718iz_nag/run/SMS_D_Ld5.f10_f10_mg37.I1850Clm60Sp.izumi_nag.mosart-default.GC.0627-180718iz_nag.mosart.h0a.0001-01-06-00000.asc /fs/cgd/data0/slevis/git/b4b-dev/tests_0627-171420iz/SMS_D_Ld5.f10_f10_mg37.I1850Clm60Sp.izumi_nag.mosart-default.GC.0627-171420iz_nag/run/SMS_D_Ld5.f10_f10_mg37.I1850Clm60Sp.izumi_nag.mosart-default.GC.0627-171420iz_nag.mosart.h0.0001-01-06-00000.asc

@slevis-lmwg slevis-lmwg requested a review from ekluzek June 28, 2025 00:11
@slevis-lmwg slevis-lmwg marked this pull request as ready for review June 28, 2025 00:12
@slevis-lmwg
Copy link
Contributor Author

slevis-lmwg commented Jun 28, 2025

@ekluzek this is ready for review/approval. The changes to mosart will look very familiar now that you have reviewed ESCOMP/CTSM#2445.

@slevis-lmwg slevis-lmwg moved this from In Progress to Done in LMWG: Sprint Planning Board Jun 28, 2025
@slevis-lmwg
Copy link
Contributor Author

For Sprint accounting purposes I consider this PR done, and I am moving the tracking to ESCOMP/RTM#32

Copy link
Contributor

@ekluzek ekluzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks similar to everything in the CTSM and RTM PR's. I ask at least one question. And some of what I had in CTSM and/or RTM might apply here as well.

But, approving so you don't have to wait on me. Thanks for all the work to bring this in. There's just a lot of changes needed that have to be done right to get it all working.

@github-project-automation github-project-automation bot moved this from In progress - release/externals / MOSART / RTM / mizu etc. tags to In progress - master in CTSM: Upcoming tags Jul 3, 2025
@ekluzek ekluzek moved this from In progress - master to In progress - release/externals / MOSART / RTM / mizu etc. tags in CTSM: Upcoming tags Jul 3, 2025
@slevis-lmwg
Copy link
Contributor Author

slevis-lmwg commented Jul 3, 2025

  • finalize and push ChangeLog

@slevis-lmwg slevis-lmwg merged commit c776a80 into ESCOMP:master Jul 4, 2025
@slevis-lmwg slevis-lmwg deleted the sep_hXi_hXa_tapes_iss52 branch July 4, 2025 00:19
@github-project-automation github-project-automation bot moved this from In progress - release/externals / MOSART / RTM / mizu etc. tags to Done (non release/external) in CTSM: Upcoming tags Jul 4, 2025
@slevis-lmwg slevis-lmwg moved this from Done (non release/external) to release/externals tags done in CTSM: Upcoming tags Jul 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: release/externals tags done
Status: Done

Development

Successfully merging this pull request may close these issues.

Separate instantaneous from non-inst. history tapes

2 participants