rtm1_0_87: Put instantaneous and non-inst. fields on separate history files#61
Merged
slevis-lmwg merged 11 commits intoESCOMP:masterfrom Jul 4, 2025
Merged
Conversation
Contributor
Author
|
@ekluzek this is ready for review/approval. The changes to rtm and mosart will look very similar to what you reviewed in ESCOMP/CTSM#2445 |
Contributor
Author
|
I changed one of the ERS tests to ERP as an additional sanity check: |
Merged
10 tasks
ekluzek
approved these changes
Jul 3, 2025
Contributor
ekluzek
left a comment
ekluzek
left a comment
There was a problem hiding this comment.
This is largely the same as what's going on in CTSM. And there's a lot of detailed work here that I'm glad you were able to do. So good job in getting it done.
I have a couple comments, and questions, but hitting approve so you don't have to wait on me.
…b05d86a42bbe4adc9dd7
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the RTM counterpart to ESCOMP/MOSART#117 and ESCOMP/CTSM#2445.
Resolves #32 (my branch name should have referenced issue #32 instead of 52)
PASS
./run_sys_tests -s rtm --skip-generate --skip-compareon derecho and izumi