Use nearest scheme to avoid interpolation errors with masked data in regression test#1021
Conversation
|
Hi @valeriupredoi , could you have a look at this one? 🚀 |
|
@stefsmeets could you please fix the failing multimodel test mate https://app.circleci.com/pipelines/github/ESMValGroup/ESMValCore/4339/workflows/a42839e2-f294-4223-834b-0afec25fda4f/jobs/20245 |
|
friendly ping @stefsmeets 👍 |
nevermind, that's happening coz the actual sample data has now changed, the Github Actions pass well, @bouweandela when is the sample data changed in the test container? |
|
Yeah, I noticed one test oddly failed in your PR. I just re-ran it before I did the review to see what happened. Not entirely sure why it magically got fixed, will keep an eye on it 👍 |
Description
This PR changes the regridder from
Linearto aNearestscheme to avoid interpolation errors on masked arrays. It also updates the regression data. This fixes an issue with the regression test that makes it difficult to compare between branches.For more info on why this happens, see also #593
Before you get started
Checklist
pre-commitoryamllintchecksTo help with the number pull requests: