Skip to content

Use nearest scheme to avoid interpolation errors with masked data in regression test#1021

Merged
valeriupredoi merged 2 commits intomasterfrom
fix_multimodel_regression_tests2
Feb 25, 2021
Merged

Use nearest scheme to avoid interpolation errors with masked data in regression test#1021
valeriupredoi merged 2 commits intomasterfrom
fix_multimodel_regression_tests2

Conversation

@stefsmeets
Copy link
Contributor

@stefsmeets stefsmeets commented Feb 25, 2021

Description

This PR changes the regridder from Linear to a Nearest scheme to avoid interpolation errors on masked arrays. It also updates the regression data. This fixes an issue with the regression test that makes it difficult to compare between branches.

For more info on why this happens, see also #593


Before you get started

Checklist


To help with the number pull requests:

@stefsmeets stefsmeets added bug Something isn't working testing labels Feb 25, 2021
@stefsmeets
Copy link
Contributor Author

Hi @valeriupredoi , could you have a look at this one? 🚀

Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, man 👍

@valeriupredoi valeriupredoi merged commit 1925fa5 into master Feb 25, 2021
@valeriupredoi valeriupredoi deleted the fix_multimodel_regression_tests2 branch February 25, 2021 10:56
@valeriupredoi
Copy link
Contributor

@stefsmeets could you please fix the failing multimodel test mate https://app.circleci.com/pipelines/github/ESMValGroup/ESMValCore/4339/workflows/a42839e2-f294-4223-834b-0afec25fda4f/jobs/20245
Always remember to run the tests locally too, since our test CI is a bit en retard and builds only off master

@valeriupredoi
Copy link
Contributor

friendly ping @stefsmeets 👍

@valeriupredoi
Copy link
Contributor

friendly ping @stefsmeets +1

nevermind, that's happening coz the actual sample data has now changed, the Github Actions pass well, @bouweandela when is the sample data changed in the test container?

@stefsmeets
Copy link
Contributor Author

Yeah, I noticed one test oddly failed in your PR. I just re-ran it before I did the review to see what happened. Not entirely sure why it magically got fixed, will keep an eye on it 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Linear regridder causes interpolation errors for masked data in sample data tests

2 participants