Skip to content

Fix bugs with large values in multimodel regression tests#1015

Closed
stefsmeets wants to merge 2 commits intomasterfrom
fix_multimodel_regression_tests
Closed

Fix bugs with large values in multimodel regression tests#1015
stefsmeets wants to merge 2 commits intomasterfrom
fix_multimodel_regression_tests

Conversation

@stefsmeets
Copy link
Contributor

@stefsmeets stefsmeets commented Feb 22, 2021

Description

This PR changes the regridder to a Nearest scheme to avoid interpolation errors on masked arrays. For more details see #1014 . I also added a check for large values, which revealed another dataset with a large unmasked value: ESMValGroup/ESMValTool_sample_data#24 that I would like to include in this PR as well.

Todo:


Before you get started

Checklist

If you make backwards incompatible changes to the recipe format:

  • Update ESMValTool and link the pull request(s) in the description

To help with the number pull requests:

@stefsmeets stefsmeets changed the title Deal with large values in multimodel regression tests Fix bugs with large values in multimodel regression tests Feb 22, 2021
@stefsmeets stefsmeets added bug Something isn't working testing labels Feb 22, 2021
Includes fix that removes dataset with large value
@stefsmeets
Copy link
Contributor Author

Closed in favour of #1021 which does not touch the sample data repo.

@stefsmeets stefsmeets closed this Feb 25, 2021
@bouweandela
Copy link
Member

Could you please delete the branch once it's not needed anymore? That way we keep the repo clean-ish.

@stefsmeets stefsmeets deleted the fix_multimodel_regression_tests branch March 2, 2021 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Linear regridder causes interpolation errors for masked data in sample data tests

2 participants