Fix bugs with large values in multimodel regression tests#1015
Closed
stefsmeets wants to merge 2 commits intomasterfrom
Closed
Fix bugs with large values in multimodel regression tests#1015stefsmeets wants to merge 2 commits intomasterfrom
stefsmeets wants to merge 2 commits intomasterfrom
Conversation
Includes fix that removes dataset with large value
This was referenced Feb 22, 2021
Contributor
Author
|
Closed in favour of #1021 which does not touch the sample data repo. |
Member
|
Could you please delete the branch once it's not needed anymore? That way we keep the repo clean-ish. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the regridder to a
Nearestscheme to avoid interpolation errors on masked arrays. For more details see #1014 . I also added a check for large values, which revealed another dataset with a large unmasked value: ESMValGroup/ESMValTool_sample_data#24 that I would like to include in this PR as well.Todo:
ESMValTool_sample_data(v0.0.5)Before you get started
Checklist
pre-commitoryamllintchecksIf you make backwards incompatible changes to the recipe format:
To help with the number pull requests: