Merged
Conversation
bouweandela
requested changes
Mar 2, 2021
Member
bouweandela
left a comment
bouweandela
left a comment
There was a problem hiding this comment.
Looks good! I think the version number does not need to be updated, because version 0.0.4 has not been released yet. Updating it now would mean we skip v0.0.4.
Co-authored-by: Bouwe Andela <b.andela@esciencecenter.nl>
bouweandela
approved these changes
Mar 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a single dataset with a very large unmasked value. This PR removes that dataset.
Fixes #24
I also bumped the version to
0.0.5so that it can be used in ESMValGroup/ESMValCore#1015