Conversation
schlunma
reviewed
Feb 4, 2022
Contributor
schlunma
left a comment
schlunma
left a comment
There was a problem hiding this comment.
Cool!
I just have a very small comment. Apart from that a small test of this would be nice.
schlunma
changed the title
Codecov Report
@@ Coverage Diff @@
## main #1472 +/- ##
==========================================
+ Coverage 89.84% 89.85% +0.01%
==========================================
Files 196 197 +1
Lines 10477 10489 +12
==========================================
+ Hits 9413 9425 +12
Misses 1064 1064
Continue to review full report at Codecov.
|
schlunma
approved these changes
Feb 7, 2022
9 tasks
axel-lauer
changed the title
Contributor
Author
|
Tested the fix for AIRS v2.1, works fine. Also tested the fix for clisccp. This did not work any more, so I reverted the changes related to clisccp. I think this it is better to address clisccp this in a seperate pull request. |
Contributor
|
Awesome, thanks Axel! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adding
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: