Skip to content

Added changelog for v2.5.0 release#1476

Merged
schlunma merged 9 commits intomainfrom
update_changelog_for_v2.5.0rc1
Feb 8, 2022
Merged

Added changelog for v2.5.0 release#1476
schlunma merged 9 commits intomainfrom
update_changelog_for_v2.5.0rc1

Conversation

@schlunma
Copy link
Contributor

@schlunma schlunma commented Feb 7, 2022

Description

Adds first version of the changelog for v2.5.0.

Link to documentation: https://esmvaltool--1476.org.readthedocs.build/projects/ESMValCore/en/1476/changelog.html#v2-5-0


Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@schlunma schlunma added the documentation Improvements or additions to documentation label Feb 7, 2022
@schlunma schlunma added this to the v2.5.0 milestone Feb 7, 2022
@schlunma schlunma self-assigned this Feb 7, 2022
@codecov
Copy link

codecov bot commented Feb 7, 2022

Codecov Report

Merging #1476 (4fff728) into main (62d21aa) will not change coverage.
The diff coverage is n/a.

❗ Current head 4fff728 differs from pull request most recent head 1f53484. Consider uploading reports for the commit 1f53484 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1476   +/-   ##
=======================================
  Coverage   90.70%   90.70%           
=======================================
  Files         197      197           
  Lines       10499    10499           
=======================================
  Hits         9523     9523           
  Misses        976      976           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62d21aa...1f53484. Read the comment docs.

Copy link
Contributor

@remi-kazeroni remi-kazeroni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me @schlunma! Thanks for preparing the Changelog!

@zklaus
Copy link

zklaus commented Feb 7, 2022

Perhaps you could follow this stackoverflow answer to provide a link that allows the user to see exactly which dependencies have changed?

@schlunma
Copy link
Contributor Author

schlunma commented Feb 7, 2022

I don't think that's worth it to be honest. Without a tag we need to mess around with commit ids and this is something I'd like to avoid 😄

@zklaus
Copy link

zklaus commented Feb 7, 2022

I don't think that's worth it to be honest. Without a tag we need to mess around with commit ids and this is something I'd like to avoid smile

If I had a dollar for everything you wanted to avoid on ESMValTool... But joking aside, I think the benefit is in being able to see what has changed between releases. Since we are adding the lock file for the first time in this release, there really is no need. Let's revisit this for the next release. Then we will also have a convenient tag.

@schlunma
Copy link
Contributor Author

schlunma commented Feb 7, 2022

It just feels bad to add dead links in a PR (the label is only available after the release, and for the release we need the changelog...).

@schlunma
Copy link
Contributor Author

schlunma commented Feb 7, 2022

I will do release tomorrow. We couldn't test some PRs that I would like to include into this release since Mistral had an unexpected downtime today.

Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gut gut 🍺

@schlunma schlunma marked this pull request as ready for review February 8, 2022 17:01
@schlunma schlunma merged commit 84d1b49 into main Feb 8, 2022
@schlunma schlunma deleted the update_changelog_for_v2.5.0rc1 branch February 8, 2022 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants