Added dataset and alias attributes to multi_model_statistics output#1483
Merged
Added dataset and alias attributes to multi_model_statistics output#1483
dataset and alias attributes to multi_model_statistics output#1483Conversation
9 tasks
Codecov Report
@@ Coverage Diff @@
## main #1483 +/- ##
=======================================
Coverage 89.85% 89.85%
=======================================
Files 197 197
Lines 10489 10492 +3
=======================================
+ Hits 9425 9428 +3
Misses 1064 1064
Continue to review full report at Codecov.
|
Contributor
Author
|
@sloosvel @valeriupredoi can you briefly take a look at this? This is the final piece that's missing for v2.5.0rc1 😄 Thanks!!! |
valeriupredoi
approved these changes
Feb 8, 2022
Contributor
valeriupredoi
left a comment
valeriupredoi
left a comment
There was a problem hiding this comment.
looks just perfect to me, man! Thank you!
Contributor
Author
|
Awesome, thanks ❤️ |
Contributor
|
Sorry for so many slipups in #673 ! |
Contributor
Author
|
No worries at all, #673 is a great addition!! It must have been hell to fix all the merge conflicts that surfaced there... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Re-adds the attributes
datasetandalias(which many diagnostics rely on) to multi_model_statistics output.Closes #1480
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: