Refactored native model fixes by adding common base class NativeDatasetFix#1694
Refactored native model fixes by adding common base class NativeDatasetFix#1694
NativeDatasetFix#1694Conversation
Codecov Report
@@ Coverage Diff @@
## main #1694 +/- ##
==========================================
+ Coverage 91.49% 91.51% +0.01%
==========================================
Files 204 205 +1
Lines 11174 11191 +17
==========================================
+ Hits 10224 10241 +17
Misses 950 950
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
I have no idea why that Codacy error ( |
remi-kazeroni
left a comment
There was a problem hiding this comment.
Thanks for your contribution @schlunma! The code looks good to me. This should help lowering the bar to add support for native model output in the future. This is also a good step towards reducing code duplication w.r.t. model fixes. The CMORization of models related to this PR gives identical results to that of the main branch and other models are not affected (different classes) so I think this is ready to be merged 👍
I have seen that in some other unrelated PRs as well, so I would agree... |
|
Awesome, thanks for the review @remi-kazeroni ! 🚀 |
Description
This PR simplifies native model fixes by adding a base class
NativeDatasetFixwith common operations necessary for almost all datasets. This will dramatically simplify #1678.Closes #1690
Link to documentation: https://esmvaltool--1694.org.readthedocs.build/projects/ESMValCore/en/1694/develop/fixing_data.html#fix-native-data
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: