Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1700 +/- ##
=======================================
Coverage 91.51% 91.51%
=======================================
Files 205 205
Lines 11191 11192 +1
=======================================
+ Hits 10241 10242 +1
Misses 950 950
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Contributor
Author
|
Tests on 3.8 now run successful: https://github.com/ESMValGroup/ESMValCore/runs/7874314356?check_suite_focus=true |
remi-kazeroni
approved these changes
Aug 17, 2022
Contributor
remi-kazeroni
left a comment
There was a problem hiding this comment.
Looks good to me, thanks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
#1694 added type annotations that are only available since Python 3.9; thus, tests are failing with Python 3.8. This PR fixes this.
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: