Skip to content

Fixed type annotations for Python 3.8#1700

Merged
schlunma merged 2 commits intomainfrom
fix_type_annotations_py38
Aug 17, 2022
Merged

Fixed type annotations for Python 3.8#1700
schlunma merged 2 commits intomainfrom
fix_type_annotations_py38

Conversation

@schlunma
Copy link
Contributor

@schlunma schlunma commented Aug 17, 2022

Description

#1694 added type annotations that are only available since Python 3.9; thus, tests are failing with Python 3.8. This PR fixes this.

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@schlunma schlunma added the bug Something isn't working label Aug 17, 2022
@schlunma schlunma added this to the v2.7.0 milestone Aug 17, 2022
@schlunma schlunma self-assigned this Aug 17, 2022
@codecov
Copy link

codecov bot commented Aug 17, 2022

Codecov Report

Merging #1700 (c7c3301) into main (613f08c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1700   +/-   ##
=======================================
  Coverage   91.51%   91.51%           
=======================================
  Files         205      205           
  Lines       11191    11192    +1     
=======================================
+ Hits        10241    10242    +1     
  Misses        950      950           
Impacted Files Coverage Δ
esmvalcore/cmor/_fixes/native_datasets.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@schlunma schlunma marked this pull request as ready for review August 17, 2022 08:46
@schlunma
Copy link
Contributor Author

@schlunma schlunma requested a review from remi-kazeroni August 17, 2022 08:46
Copy link
Contributor

@remi-kazeroni remi-kazeroni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks

@schlunma schlunma merged commit 8b4c1b2 into main Aug 17, 2022
@schlunma schlunma deleted the fix_type_annotations_py38 branch August 17, 2022 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants