Merged
Conversation
bouweandela
force-pushed
the
enable-bugbear-rule
branch
from
eb242a1 to
a07f235
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2536 +/- ##
==========================================
+ Coverage 94.91% 95.01% +0.09%
==========================================
Files 251 251
Lines 14264 14264
==========================================
+ Hits 13539 13553 +14
+ Misses 725 711 -14 ☔ View full report in Codecov by Sentry. |
Member
Author
|
Regarding the test coverage: I am not sure how to test the import in |
schlunma
approved these changes
Oct 15, 2024
Contributor
schlunma
left a comment
schlunma
left a comment
There was a problem hiding this comment.
❤️
Just one tiny comment, thanks!!
Co-authored-by: Manuel Schlund <32543114+schlunma@users.noreply.github.com>
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Enable the flake8-bugbear ruff linter rule.
As recommended by https://learn.scientific-python.org/development/guides/repo-review/?repo=esmvalgroup%2Fesmvalcore&branch=main
Related to #2528
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: