Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2547 +/- ##
=======================================
Coverage 95.01% 95.01%
=======================================
Files 251 251
Lines 14268 14268
=======================================
Hits 13557 13557
Misses 711 711 ☔ View full report in Codecov by Sentry. |
schlunma
approved these changes
Oct 15, 2024
Contributor
schlunma
left a comment
schlunma
left a comment
There was a problem hiding this comment.
Great, thanks! I only have some tiny comments.
tests/integration/preprocessor/_regrid/test_extract_coordinate_points.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Manuel Schlund <32543114+schlunma@users.noreply.github.com>
Contributor
|
sorry @bouweandela I messed up your clean merge by merging #2536 first - could you pls fix the conflict? Merge at will after, I will approve now 🍺 |
valeriupredoi
approved these changes
Oct 16, 2024
Contributor
valeriupredoi
left a comment
valeriupredoi
left a comment
There was a problem hiding this comment.
actually, maybe address me comments in #2540 first, then merge that into main, then come back here - bet there'll be conflicts again in pyproject.toml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Enable pydocstyle again, but now with ruff.
Related to #2528
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: