Use pyproject.toml instead of setup.py/setup.cfg

[bouweandela]

Description

Use pyproject.toml instead of setup.py/setup.cfg, as this is the modern way of doing things.

Also added some improvements suggested by https://learn.scientific-python.org/development/guides/repo-review/?repo=esmvalgroup%2Fesmvalcore&branch=pyproject-toml

Link to documentation: https://esmvaltool--2540.org.readthedocs.build/projects/ESMValCore/en/2540/contributing.html

Related to ESMValGroup/ESMValTool#3584

---

Before you get started

• ☝ Create an issue to discuss what you are going to do

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

• 🧪 The new functionality is relevant and scientifically sound
• 🛠 This pull request has a descriptive title and labels
• 🧪 and 🛠 Documentation is available
• 🛠 Changes are backward compatible
• 🛠 The list of authors is up to date
• 🛠 All checks below this pull request were successful - except that a line that has been reformatted by ruff (probably because we now specify the required python version) is not covered by tests

---

To help with the number pull requests:

• 🙏 We kindly ask you to review two other open pull requests in this repository

[codecov]

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 94.77%. Comparing base (e69ec5d) to head (50e09ff).
Report is 46 commits behind head on main.

Files with missing lines	Patch %	Lines
esmvalcore/_task.py	66.66%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2540      +/-   ##
==========================================
- Coverage   95.01%   94.77%   -0.25%     
==========================================
  Files         251      251              
  Lines       14268    14266       -2     
==========================================
- Hits        13557    13520      -37     
- Misses        711      746      +35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[valeriupredoi]

absolutely YES for this 🍺

[schlunma]

Great, thanks Bouwe, I really like this! 🚀

There's one more suggestion at https://learn.scientific-python.org/development/guides/repo-review/?repo=esmvalgroup%2Fesmvalcore&branch=pyproject-toml about pyproject:

[PP309](https://learn.scientific-python.org/development/guides/pytest#PP309): Filter warnings specified

filterwarnings must be set (probably to at least ["error"]). Python will hide important warnings otherwise, like deprecations.

[tool.pytest.ini_options]
filterwarnings = ["error"]

Would it make sense to implement this as well?

[bouweandela]

Would it make sense to implement this as well?

I tried, but it causes the tests to fail because some of our dependencies are using deprecated features. It would be good to enable that though, but it will require extra work.

[bouweandela]

Would it make sense to implement this as well?

I tried, but it causes the tests to fail because some of our dependencies are using deprecated features. It would be good to enable that though, but it will require extra work.

Created #2555 as a reminder.

[schlunma]

Great, thanks Bouwe!!

[valeriupredoi]

very cool! A few remoarks from me only, but I think we now need to add importlib_metadata to our deps if we use it directly

[valeriupredoi]

PS: will remove the three bits in the Github Action, just need to see those slow OSX tests pass first

just the call to run GA, Mambaforge can bite the dust via here, am just about to open a PR to remove it from the other tests too

[bouweandela]

we now need to add importlib_metadata to our deps if we use it directly

Can you point me to a line of code where it is used? I couldn't find any.

[valeriupredoi]

we now need to add importlib_metadata to our deps if we use it directly

Can you point me to a line of code where it is used? I couldn't find any.

nevermind, it was from importlib.metadata - dot is essential, V 😁

[valeriupredoi]

soz, conflict - want me to fix it? 🍺

[bouweandela]

No thanks, I'm on it.

[valeriupredoi]

superb @bouweandela 🥳