Skip to content

Remove use of prospector and related tools and Codacy#2818

Merged
bouweandela merged 2 commits intomainfrom
drop-prospector
Aug 26, 2025
Merged

Remove use of prospector and related tools and Codacy#2818
bouweandela merged 2 commits intomainfrom
drop-prospector

Conversation

@bouweandela
Copy link
Member

@bouweandela bouweandela commented Aug 21, 2025

Description

We have now switched to ruff for linting, so we can stop using prospector and related tools. Since all linter rules enabled in ruff are enforced by pre-commit.ci, we no longer need Codacy either.

Closes #2528
Closes #2684

Link to documentation: https://esmvaltool--2818.org.readthedocs.build/projects/ESMValCore/en/2818/contributing.html#code-quality


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@bouweandela bouweandela added documentation Improvements or additions to documentation testing labels Aug 21, 2025
@codecov
Copy link

codecov bot commented Aug 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.45%. Comparing base (464ddee) to head (984e01a).
⚠️ Report is 59 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2818      +/-   ##
==========================================
- Coverage   95.46%   95.45%   -0.01%     
==========================================
  Files         260      260              
  Lines       15510    15510              
==========================================
- Hits        14806    14805       -1     
- Misses        704      705       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bouweandela bouweandela marked this pull request as ready for review August 21, 2025 08:03
Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

brilliant! We're finally here, cheers @bouweandela 🍺

@valeriupredoi
Copy link
Contributor

I think you can safely close #1005 with this too

@bouweandela bouweandela merged commit ae9c6e8 into main Aug 26, 2025
6 checks passed
@bouweandela bouweandela deleted the drop-prospector branch August 26, 2025 13:53
@bouweandela bouweandela mentioned this pull request Aug 26, 2025
7 tasks
jlenh pushed a commit that referenced this pull request Sep 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace prospector with ruff integrated in Codacy

2 participants