Remove use of prospector and related tools and Codacy#2818
Merged
bouweandela merged 2 commits intomainfrom Aug 26, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2818 +/- ##
==========================================
- Coverage 95.46% 95.45% -0.01%
==========================================
Files 260 260
Lines 15510 15510
==========================================
- Hits 14806 14805 -1
- Misses 704 705 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
valeriupredoi
approved these changes
Aug 21, 2025
Contributor
valeriupredoi
left a comment
There was a problem hiding this comment.
brilliant! We're finally here, cheers @bouweandela 🍺
Contributor
|
I think you can safely close #1005 with this too |
jlenh
pushed a commit
that referenced
this pull request
Sep 3, 2025
(cherry picked from commit ae9c6e8)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We have now switched to ruff for linting, so we can stop using prospector and related tools. Since all linter rules enabled in
ruffare enforced by pre-commit.ci, we no longer need Codacy either.Closes #2528
Closes #2684
Link to documentation: https://esmvaltool--2818.org.readthedocs.build/projects/ESMValCore/en/2818/contributing.html#code-quality
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: