Improve sample script for tests for multimodel statistics preprocessor function#4
Merged
stefsmeets merged 11 commits intomasterfrom Nov 10, 2020
Merged
Improve sample script for tests for multimodel statistics preprocessor function#4stefsmeets merged 11 commits intomasterfrom
stefsmeets merged 11 commits intomasterfrom
Conversation
11 tasks
Member
Author
|
Doing acceptable horizontal slicing of ocean data is more difficult than expected. Will use just variable |
stefsmeets
approved these changes
Nov 10, 2020
Contributor
stefsmeets
left a comment
stefsmeets
left a comment
There was a problem hiding this comment.
Looks good! I just tested it on my machine and it runs without issues.
My only comment would be to move sample_data.py to the root directory and name it something more descriptive like download_sample_data.py
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add ocean datasetsThis needs better support for slicing grids with 2D lat/lon coordinates in iris first