Merged
Conversation
williamwoldum
force-pushed
the
92-testing-reveaal-endpoints
branch
from
80109f7 to
86960e8
Compare
williamwoldum
added
enhancement
sabotack
approved these changes
Dec 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does decouple the
.envconfiguration ofreveaal_serviceinto main.This keeps all configuration in main and allows us to spin up reveaal services connected to different servers.
This PR intended to write some tests for the
reveaal_serviceimplementation.However, we were unsuccessful mocking the reveaal gRPC server connection.
We tried a crate called "wiremock_grpc", but there was a versioning error with
prostwhich we could not solve.We have left the test code (that should run) as an
ignoredtest for someone in the future.