Crash in lightningd

[yaslama]

Issue and Steps to Reproduce

2023-12-10T09:09:08.761Z **BROKEN** lightningd: Sending closingd an invalid message
2023-12-10T09:09:08.793Z **BROKEN** lightningd: FATAL SIGNAL 6 (version 23.11)
2023-12-10T09:09:08.793Z **BROKEN** lightningd: backtrace: common/daemon.c:38 (send_backtrace) 0x55b8a3a2daa7
2023-12-10T09:09:08.793Z **BROKEN** lightningd: backtrace: common/daemon.c:75 (crashdump) 0x55b8a3a2daf6
2023-12-10T09:09:08.793Z **BROKEN** lightningd: backtrace: (null):0 ((null)) 0x7f05af05afcf
2023-12-10T09:09:08.793Z **BROKEN** lightningd: backtrace: (null):0 ((null)) 0x7f05af0a9d3c
2023-12-10T09:09:08.793Z **BROKEN** lightningd: backtrace: (null):0 ((null)) 0x7f05af05af31
2023-12-10T09:09:08.793Z **BROKEN** lightningd: backtrace: (null):0 ((null)) 0x7f05af045471
2023-12-10T09:09:08.793Z **BROKEN** lightningd: backtrace: lightningd/log.c:1025 (fatal_vfmt) 0x55b8a39dc556
2023-12-10T09:09:08.793Z **BROKEN** lightningd: backtrace: lightningd/log.c:1035 (fatal) 0x55b8a39dc5f5
2023-12-10T09:09:08.793Z **BROKEN** lightningd: backtrace: lightningd/subd.c:841 (subd_send_msg) 0x55b8a3a07d16
2023-12-10T09:09:08.793Z **BROKEN** lightningd: backtrace: lightningd/channel_control.c:83 (channel_update_feerates) 0x55b8a39bc850
2023-12-10T09:09:08.793Z **BROKEN** lightningd: backtrace: lightningd/channel_control.c:96 (try_update_feerates) 0x55b8a39bc895
2023-12-10T09:09:08.793Z **BROKEN** lightningd: backtrace: lightningd/channel_control.c:165 (notify_feerate_change) 0x55b8a39bc8e9
2023-12-10T09:09:08.793Z **BROKEN** lightningd: backtrace: lightningd/chaintopology.c:560 (update_feerates) 0x55b8a39b6112
2023-12-10T09:09:08.793Z **BROKEN** lightningd: backtrace: lightningd/bitcoind.c:338 (estimatefees_callback) 0x55b8a39b3837
2023-12-10T09:09:08.793Z **BROKEN** lightningd: backtrace: lightningd/plugin.c:660 (plugin_response_handle) 0x55b8a39fcf8d
2023-12-10T09:09:08.793Z **BROKEN** lightningd: backtrace: lightningd/plugin.c:772 (plugin_read_json_one) 0x55b8a3a005d3
2023-12-10T09:09:08.793Z **BROKEN** lightningd: backtrace: lightningd/plugin.c:823 (plugin_read_json) 0x55b8a3a0086b
2023-12-10T09:09:08.793Z **BROKEN** lightningd: backtrace: ccan/ccan/io/io.c:59 (next_plan) 0x55b8a3ba1817
2023-12-10T09:09:08.793Z **BROKEN** lightningd: backtrace: ccan/ccan/io/io.c:407 (do_plan) 0x55b8a3ba1cf2
2023-12-10T09:09:08.793Z **BROKEN** lightningd: backtrace: ccan/ccan/io/io.c:417 (io_ready) 0x55b8a3ba1d8f
2023-12-10T09:09:08.793Z **BROKEN** lightningd: backtrace: ccan/ccan/io/poll.c:453 (io_loop) 0x55b8a3ba372c
2023-12-10T09:09:08.793Z **BROKEN** lightningd: backtrace: lightningd/io_loop_with_timers.c:22 (io_loop_with_timers) 0x55b8a39d4ad0
2023-12-10T09:09:08.793Z **BROKEN** lightningd: backtrace: lightningd/lightningd.c:1334 (main) 0x55b8a39d9d75
2023-12-10T09:09:08.793Z **BROKEN** lightningd: backtrace: (null):0 ((null)) 0x7f05af0461c9
2023-12-10T09:09:08.793Z **BROKEN** lightningd: backtrace: (null):0 ((null)) 0x7f05af046284
2023-12-10T09:09:08.793Z **BROKEN** lightningd: backtrace: (null):0 ((null)) 0x55b8a39b1d64
2023-12-10T09:09:08.793Z **BROKEN** lightningd: backtrace: (null):0 ((null)) 0xffffffffffffffff

getinfo output

{
   "version": "23.11",
   "network": "bitcoin",
   "our_features": {
      "init": "08a0000a8a69a2",
      "node": "0200000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000088a0000a8a69a2",
      "channel": "",
      "invoice": "02000002024100"
   }
}

[cdecker]

Are there any special configurations, such as ignore_fee_limits applied via setchannel or ignore-fee-limits in the config itself?

Interestingly this is sending a channeld_feerates message (type 1027) to closingd which suggests that there is a missing check that only non-closingd should receive that message, or handle it correctly in closingd.

@rustyrussell does that sound correct?

[yaslama]

Are there any special configurations, such as ignore_fee_limits applied via setchannel or ignore-fee-limits in the config itself?

No ignore_fee_limits was applied via setchannel and no ignore-fee-limits in the config file.

[kingonly]

@vincenzopalazzo does it mean we won't have a hotfix for this issue? Our (Breez) production node keeps crashing.

[vincenzopalazzo]

does it mean we won't have a hotfix for this issue? Our (Breez) production node keeps crashing.

If a hot fix is required we will make it so the cln team will not oppose it.

I can look at this if the breeze node needs it @kingonly

[kingonly]

does it mean we won't have a hotfix for this issue? Our (Breez) production node keeps crashing.

If a hot fix is required we will make it so the cln team will not oppose it.

I can look at this if the breeze node needs it @kingonly

Thank you @vincenzopalazzo, we would greatly appreciate a hot fix for this crash as this seems to constantly happen.

[vincenzopalazzo]

I can try to patch the crash but then maybe @cdecker or any of the team will be the correct people to ask for a possible hotfix 😄 I just push code around

but lets fix it before