subd: Do not send feerate updates to non-channeld subds#6937
Merged
cdecker merged 1 commit intoDec 12, 2023
Conversation
Turns out we were sending feerate updates to daemons that do not understand it. Don't do that! Closes ElementsProject#6932 Changelog-Fixed: channeld: We could crash `closingd` by sending it a `channeld` message
Collaborator
|
@cdecker: I ran into this today too. Wouldn't a cleaner fix be to drop https://github.com/ElementsProject/lightning/blob/v23.11/lightningd/channel.h#L518 Then the Addendum: Note that in v23.05.2, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out we were sending feerate updates to daemons that do not understand it. Don't do that!
Closes #6932
Changelog-Fixed: channeld: We could crash
closingdby sending it achanneldmessage