hsmtools: a plugin for all things hsm_secret#3177
Closed
darosior wants to merge 4 commits into
Closed
Conversation
This adds a new plugin, hsmtools, which allows one to decrypt its encrypted hsm_secret via RPC.
Closed
Contributor
Author
Contributor
Author
|
Hmm I wonder if it makes sense to include it in lightningd/plugins instead ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This not really all things since I wanted to also move
signmessageandcheckmessageto the plugin, but then if thehsm_secretis encrypted the user would need to also pass its encryption password. What do you think ? (They can also be added later)So this comports only two calls ATM :
decrypthsmandencrypthsm. This also moves the encryption doc in the README to the "Further information" part.