Non-plugin version of hsmtool by darosior · Pull Request #3186 · ElementsProject/lightning

darosior · 2019-10-19T15:40:37Z

This closes #3177 as it is a concurrent version of the hsmtools functionalities.

Changelog-None

niftynei · 2019-10-21T12:15:16Z

+	close(fd);
+
+	/* Create a backup file, "just in case". */
+	rename(hsm_secret_path, "hsm_secret.backup");


does rename update just the file name, or the entire path?

entire path

a bit of a stretch goal, but it'd be nice if it's in the same directory as the original hsm file, so that it's easy to find/recover in case of a problem

Actually it was in plugin version (we chdir in libplugin.c at init) but I kept it although we don"t run it from the same directory.
In case of a not-already handled problem, the backup is still in the running directory.. And it would be quite hacky, just for a tool : recovering the path to the lightning-dir from the hsm_secret path, then prefixing the rename..

darosior · 2019-10-21T14:15:49Z

Thanks for the review, I am about to push the polish and the dumpcommitments method. I'll integrate your comments.

Sjors · 2019-10-21T16:33:01Z

Nice! I prefer Co-Authored-By: Sjors Provoost <sjors@sprovoost.nl> over an @ mention in the commit, because the latter can lead to lots of altcoin spam... (when they get around to cloning this)

Can you add a (optional) node public key argument to dumpcommitments? I don't know if this gets purged from the database 30 (?) days after channel closure, but regardless it's nice to be able to dump a commitment without having access to the full database.

darosior · 2019-10-21T16:35:24Z

Nice! I prefer Co-Authored-By: Sjors Provoost sjors@sprovoost.nl over an @ mention in the commit, because the latter can lead to lots of altcoin spam... (when they get around to cloning this)

Sure, will do

(when they get around to cloning this)

😂

darosior · 2019-10-21T16:37:34Z

Great, Github even takes it into account.

darosior · 2019-10-22T11:20:24Z

Can you add a (optional) node public key argument to dumpcommitments? I don't know if this gets purged from the database 30 (?) days after channel closure, but regardless it's nice to be able to dump a commitment without having access to the full database.

Yes, you right this should be the default I think.

Sjors · 2019-10-22T13:53:05Z

I'm able to produce the same commitment point with this PR as with my original tool. However it's a bit confusing that index 0 is referred to as depth 1.

darosior · 2019-10-22T20:40:13Z

Polished, corrected, and rebased on master.

rustyrussell

Looks good, minor updates only...

rustyrussell · 2019-11-10T23:49:16Z

+	if (close(fd) != 0)
+		return false;
+
+	fd = open(".", O_RDONLY);


This is fsyncing the wrong dir? You want dirname(hsm_secret_path) here.

Bad copy/paste!

rustyrussell · 2019-11-10T23:50:35Z

 	printf("./hsmtools <method> [arguments]\n");
 	printf("methods:\n");
 	printf("	- decrypthsm <path/to/hsm_secret> <password>\n");
+	printf("	- encrypthsm <path/to/hsm_secret> <password>\n");


Since the tool is call htmtools, we could just call these commands "decrypt" and "encrypt" perhaps? And maybe "hsmtool" is better than "hsmtools" though that's marginal.

Yeah I wanted to add more tools (#3217) but I can make it singular ^^

rustyrussell · 2019-11-10T23:54:14Z

+
+	fd = open(hsm_secret_path, O_RDONLY);
+	if (fd < 0)
+		errx(ERROR_HSM_FILE, "Could not open hsm_secret");


Use err() not errx() here, which will tell them what the error was?

err.. I confused the err functions

rustyrussell · 2019-11-10T23:54:24Z

+	if (fd < 0)
+		errx(ERROR_HSM_FILE, "Could not open hsm_secret");
+	if (!read_all(fd, hsm_secret, sizeof(*hsm_secret)))
+		errx(ERROR_HSM_FILE, "Could not read hsm_secret");


Here too...

A general one, for all things hsm_secret.

And tell about decryption/encryption with hsmtool

This takes a dbid, a "depth" (how many points to dump), the hsm_secret path, and a potential password to dump informations about all commitments until the depth. Co-Authored-By: Sjors Provoost <sjors@sprovoost.nl>

darosior · 2019-11-11T13:46:47Z

Corrected the fsync and the confusion between err functions, renamed encryption methods to encrypt and decrypt, and renamed the tool to hsmtool. Thanks for the review!

rustyrussell

Ack aacb721

Nice work!

darosior requested a review from cdecker as a code owner October 19, 2019 15:40

niftynei reviewed Oct 21, 2019

View reviewed changes

darosior force-pushed the hsm_tools_rework branch from af297fe to 5301ce3 Compare October 21, 2019 16:26

darosior force-pushed the hsm_tools_rework branch from 5301ce3 to e2d72dd Compare October 21, 2019 16:37

darosior force-pushed the hsm_tools_rework branch 3 times, most recently from 8744f16 to 04a42b5 Compare October 22, 2019 09:15

darosior force-pushed the hsm_tools_rework branch from 04a42b5 to 26bf34e Compare October 22, 2019 11:44

Sjors mentioned this pull request Oct 22, 2019

Add devtools/mkpoint #3115

Closed

darosior mentioned this pull request Oct 28, 2019

hsmtools: add a tool to recover a to_remote output from peer unilateral close #3217

Closed

rustyrussell requested a review from niftynei November 5, 2019 04:51

rustyrussell reviewed Nov 10, 2019

View reviewed changes

darosior and others added 6 commits November 11, 2019 14:13

pytest: clean up hsm_secret_encryption test

a26e6a4

tools/hsmtool: add a tool for decrypting hsm_secret

1b8e224

A general one, for all things hsm_secret.

tools/hsmtool: add a tool for encrypting hsm_secret

5a5fc13

pytest: test hsm_secret management with hsmtool

c65e2ed

README: move hsm_secret encryption infos into a dedicated part

c668230

And tell about decryption/encryption with hsmtool

hsmtool: add a tool to dump commitment points and secrets

aacb721

This takes a dbid, a "depth" (how many points to dump), the hsm_secret path, and a potential password to dump informations about all commitments until the depth. Co-Authored-By: Sjors Provoost <sjors@sprovoost.nl>

darosior force-pushed the hsm_tools_rework branch from 26bf34e to aacb721 Compare November 11, 2019 13:45

darosior changed the title ~~Non-plugin version of hsmtools~~ Non-plugin version of hsmtool Nov 11, 2019

rustyrussell approved these changes Nov 12, 2019

View reviewed changes

rustyrussell merged commit de91eda into ElementsProject:master Nov 12, 2019

darosior deleted the hsm_tools_rework branch November 25, 2019 14:08

guggero mentioned this pull request Dec 16, 2019

unconfirmed channels are not included in channel backup when using gRPC lightningnetwork/lnd#3816

Closed

Conversation

darosior commented Oct 19, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

darosior commented Oct 21, 2019

Uh oh!

Sjors commented Oct 21, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

darosior commented Oct 21, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

darosior commented Oct 21, 2019

Uh oh!

darosior commented Oct 22, 2019

Uh oh!

Sjors commented Oct 22, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

darosior commented Oct 22, 2019

Uh oh!

rustyrussell left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

darosior commented Nov 11, 2019

Uh oh!

rustyrussell left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

darosior commented Oct 19, 2019 •

edited

Loading

Sjors commented Oct 21, 2019 •

edited

Loading

darosior commented Oct 21, 2019 •

edited

Loading

Sjors commented Oct 22, 2019 •

edited

Loading