sphinx: Actually use the pad stream to generate the packet#3427
Merged
Conversation
cdecker
force-pushed
the
sphinx-spec-padding
branch
2 times, most recently
from
6d0b7a1 to
f64e015
Compare
Member
Author
|
This is now ready for review. Ping @ZmnSCPxj and @rustyrussell |
ZmnSCPxj
approved these changes
Jan 27, 2020
We flipped two buffers and were not actually using the chacha20 stream.
We were for some reason encoding all payloads as raw payloads instead of loading legacy payloads into a padded array.
This avoids having to re-serialize the block header just to compute the hash. It also frees us from having to carry around all the details in the header and we can hand around a minimal version.
cdecker
force-pushed
the
sphinx-spec-padding
branch
from
f64e015 to
2368e8a
Compare
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out #3246 did not actually do anything. We flipped two buffers and were not actually using the chacha20 stream. The buffer we were initializing with the chacha20 stream was simply being overwritten in the next iteration. We need to initialize the
packet->routinginfoinstead.Keeping this as a draft until we've resolved the broken test-vectors in lightning/bolts#697
Changelog-None