Conversation
Signed-off-by: Peter Neuroth <pet.v.ne@gmail.com>
Turns out we were sending feerate updates to daemons that do not understand it. Don't do that! Closes #6932 Changelog-Fixed: channeld: We could crash `closingd` by sending it a `channeld` message
As reported by @wtogami, LND nodes are using a default min_final_cltv_expiry_delta of 9, which makes them unable to pay invoices using the modern spec default of 18. Forcing inclusion of the c field allows interoperability until broader support of the 18 block default. Fixes: #6956 Changelog-Fixed: Default bolt11 invoices are payable by LND nodes.
Member
Author
|
I got the following reprobuild results after tagging Now recompiling from scratch to verify before signing and uploading. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@endothermicdev discovered that lnd nodes still default to a final CLTV delta of 9 blocks rather than the 18 blocks (3 years ago: lightning/bolts#785).
We were always adding this optional parameter during the migration from default=9 to default=18 to prevent ambiguity, but it turns out that migration phase is not complete, and there are old implementations still defaulting to 9 blocks.
This hotfix just undoes that optional parameter and now always includes it.