Conversation
This looks like it might be an issue upstream in |
|
I suspect this is blocked on this PR getting into a release (whether cc @bitshifter ( |
|
If I patch glam to latest main the problem goes away. |
Make sure to run Also, remember to mark the commit as "ready for review" and ping me to look at once, once it's 100% ready. |
Sorry. I had forgotten about this PR 😓 |
|
This seems to work for us now. |
crates/spirv-std/Cargo.toml
Outdated
| @@ -12,7 +12,7 @@ spirv-std-types.workspace = true | |||
| spirv-std-macros.workspace = true | |||
| bitflags = "1.2.1" | |||
| num-traits = { version = "0.2.14", default-features = false, features = ["libm"] } | |||
There was a problem hiding this comment.
| num-traits = { version = "0.2.14", default-features = false, features = ["libm"] } | |
| num-traits = { version = "0.2.15", default-features = false, features = ["libm"] } |
... this is all it takes to make 0.23 work, too, I'm so sorry for not noticing this earlier!
(EDIT: unresolved this to leave it visible as an explanation)
Co-authored-by: Eduard-Mihai Burtescu <eddyb@lyken.rs>
eddyb
left a comment
There was a problem hiding this comment.
Let's do the range thing now that we know raising the num-traits dependency is enough to support 0.23, and don't forget to add a CHANGELOG entry along the lines of "relaxing glam version requirements" or something (i.e. we should specify the range we support, not just say we updated).
eddyb
left a comment
There was a problem hiding this comment.
(sorry for the back & forth, I'll apply these suggestions myself to land this)
|
Btw, one of the reasons we can keep using a range is that we actually do have a bit of testing, from: That is, |
0.24.0glam support up to version 0.24.0.
We would like update glam version to match other dependencies.