This repository was archived by the owner on Oct 31, 2025. It is now read-only.
ci: add custom lint for spirv-std building with -Z minimal-versions.#1054
Merged
eddyb merged 4 commits intoEmbarkStudios:mainfrom May 19, 2023
LykenSol:version-test
Merged
ci: add custom lint for spirv-std building with -Z minimal-versions.#1054eddyb merged 4 commits intoEmbarkStudios:mainfrom LykenSol:version-test
spirv-std building with -Z minimal-versions.#1054eddyb merged 4 commits intoEmbarkStudios:mainfrom
LykenSol:version-test
Conversation
Contributor
Author
|
CI fails as expected, will push fix commit now. |
eddyb
commented
Apr 26, 2023
| proc-macro2 = "1.0.24" | ||
| quote = "1.0.8" | ||
| syn = { version = "1.0.58", features = ["full", "visit-mut"] } | ||
| syn = { version = "1.0.85", features = ["full", "visit-mut"] } |
Contributor
Author
There was a problem hiding this comment.
Should we consider switching to syn 2.0.0?
I guess even if we do, I still want to land the CI check separately.
Contributor
There was a problem hiding this comment.
yeah we can definitely switch
repi
approved these changes
May 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This tries to prevent issues like:
spirv-std-macroswith oldCargo.lock. #1053Note that the separation into commits is to aid review, and also I'm going to open this PR without the fix for the failure, so that I can demonstrate CI failing with the new check.