Check for duplicate flows

[tsmbland]

Description

Adds a check to make sure no process has multiple flows for the same commodity

Fixes #248

Type of change

• Bug fix (non-breaking change to fix an issue)
• New feature (non-breaking change to add functionality)
• Refactoring (non-breaking, non-functional change to improve maintainability)
• Optimization (non-breaking change to speed up the code)
• Breaking change (whatever its nature)
• Documentation (improve or add documentation)

Key checklist

• All tests pass: $ cargo test
• The documentation builds and looks OK: $ cargo doc

Further checks

• Code is commented, particularly in hard-to-understand areas
• Tests added that prove fix is effective or that feature works

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.82%. Comparing base (6df67e7) to head (6a0852e).

Additional details and impacted files

@@                  Coverage Diff                   @@
##           combine-pacs-flows     #353      +/-   ##
======================================================
+ Coverage               95.74%   95.82%   +0.07%     
======================================================
  Files                      27       27              
  Lines                    3129     3182      +53     
  Branches                 3129     3182      +53     
======================================================
+ Hits                     2996     3049      +53     
  Misses                     61       61              
  Partials                   72       72              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[alexdewar]

One small suggestion, but otherwise all good.

I suppose another way to do this would be to turn flows into a HashMap, with commodity IDs as the keys, which would also make it easier to look flows up by commodity ID. We could then check for duplicates when we populate it. But I think that's a job for another day (and would probably conflict with other things like what @TinyMarsh is working on anyway).

[alexdewar]

Oops! I figured it would be easier if I merged #352, but it automatically closed this PR 🤷. I can't seem to edit it to change the target branch to main. Maybe you can @tsmbland?

[tsmbland]

Hmm weird, no I can't seem to. Usually it automatically changes the target branch...

[alexdewar]

Right? I'm not sure what's happened here... I guess you'll have to make another PR. Sorry 😟

[tsmbland]

New (identical) PR - #354