Skip to content

Comments

Check for duplicate flows#354

Merged
tsmbland merged 3 commits intomainfrom
duplicate_flows
Jan 23, 2025
Merged

Check for duplicate flows#354
tsmbland merged 3 commits intomainfrom
duplicate_flows

Conversation

@tsmbland
Copy link
Collaborator

Description

Adds a check to make sure no process has multiple flows for the same commodity

Fixes #248

Type of change

  • Bug fix (non-breaking change to fix an issue)
  • New feature (non-breaking change to add functionality)
  • Refactoring (non-breaking, non-functional change to improve maintainability)
  • Optimization (non-breaking change to speed up the code)
  • Breaking change (whatever its nature)
  • Documentation (improve or add documentation)

Key checklist

  • All tests pass: $ cargo test
  • The documentation builds and looks OK: $ cargo doc

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

tsmbland and others added 3 commits January 23, 2025 16:42
Co-authored-by: Alex Dewar <alexdewar@users.noreply.github.com>
@tsmbland tsmbland requested a review from alexdewar January 23, 2025 16:47
@codecov
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.82%. Comparing base (4361d9f) to head (c6364b6).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #354      +/-   ##
==========================================
+ Coverage   95.74%   95.82%   +0.07%     
==========================================
  Files          27       27              
  Lines        3129     3182      +53     
  Branches     3129     3182      +53     
==========================================
+ Hits         2996     3049      +53     
  Misses         61       61              
  Partials       72       72              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tsmbland tsmbland mentioned this pull request Jan 23, 2025
10 tasks
@tsmbland tsmbland enabled auto-merge January 23, 2025 16:49
Copy link
Collaborator

@alexdewar alexdewar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tsmbland tsmbland merged commit e611759 into main Jan 23, 2025
7 checks passed
@tsmbland tsmbland deleted the duplicate_flows branch January 23, 2025 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Check that no commodity is both an input and an output of a process

2 participants