Skip to content

Convert setup.cfg to pyproject.toml and add entrypoint.#118

Merged
dalonsoa merged 6 commits intoEnergySystemsModellingLab:develop_imperialfrom
ImperialCollegeLondon:setup_pyproject_conversion
May 22, 2023
Merged

Convert setup.cfg to pyproject.toml and add entrypoint.#118
dalonsoa merged 6 commits intoEnergySystemsModellingLab:develop_imperialfrom
ImperialCollegeLondon:setup_pyproject_conversion

Conversation

@jamesturner246
Copy link
Contributor

@jamesturner246 jamesturner246 commented May 19, 2023

Description

Moved most of that is possible from setup.cfg into pyproject.toml.

Added an entry point via src/muse/main.py to pyproject.toml. MUSE can now be called via muse command after installation

bumpversion and flake8 do not yet support pyproject.toml, and remain in setup.cfg.

NEEDS INFO: bump2version fails doe to incorrect initial version in setup.cfg bumpversion

Fixes #103
Fixes #108

Type of change

  • New feature (non-breaking change which adds functionality)
  • Optimization (non-breaking, back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Key checklist

  • All tests pass: $ python -m pytest
  • The documentation builds and looks OK: $ python setup.py build_sphinx

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@jamesturner246 jamesturner246 changed the base branch from develop to develop_imperial May 19, 2023 13:00
@jamesturner246 jamesturner246 changed the title Moved all that can be moved from setup.cfg to pyproject.toml. Convert setup.cfg to pyproject.toml and add entrypoint. May 20, 2023
@jamesturner246
Copy link
Contributor Author

Fixes #108

@dalonsoa dalonsoa linked an issue May 22, 2023 that may be closed by this pull request
@dalonsoa
Copy link
Collaborator

@jamesturner246 , it seems that the QA side of things is facing in this one because isort and black are modifying the source code.

It is not mentioned anywhere - another thing to add to the todo list - but you should install and run pre-commit, so the quality assurance tooling is run with each commit you make. I'm surprised that black is modifying a couple of files that, as far as I know, you did not modified locally, so make sure that the configuration in VSCode for reformatting files is not overwriting the project configuration.

@jamesturner246
Copy link
Contributor Author

Got it. I have pre-commit installed now. The more you know..

@dalonsoa dalonsoa merged commit 7a057e2 into EnergySystemsModellingLab:develop_imperial May 22, 2023
@dalonsoa dalonsoa deleted the setup_pyproject_conversion branch May 22, 2023 17:29
@dalonsoa dalonsoa mentioned this pull request May 23, 2023
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Convert muse into a command Move information from the legacy setup.cfg to pyproject.toml

2 participants

Comments