Updating pyproject.toml with valid python versions#121
Merged
dalonsoa merged 7 commits intoEnergySystemsModellingLab:develop_imperialfrom May 23, 2023
Merged
Conversation
Collaborator
|
This QA is facing but because of something to change in #118 , so nothing to do here until that is sorted. @jamesturner246 , let @TinyMarsh know when you're done with that one so he can rebase. |
Contributor
|
@TinyMarsh @dalonsoa fixed in #118. Was just commas and whitespace fuss. |
0b69bae to
6dab36c
Compare
Contributor
Author
|
I prematurely rebased. It seems I should wait until #118 is merged before rebasing this branch. |
Collaborator
|
#118 Merged! All yours! |
Contributor
Author
|
@dalonsoa Rebased and ready for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses #105 updating the
pyproject.tomlfile to include the Python versions which were included in the CI workflow in #119 . Specifically, the valid versions that MUSE can now be installed in are 3.8 and 3.9.Closes #105
Key checklist
$ python -m pytest$ python setup.py build_sphinxFurther checks