Min production considered in supply

[dalonsoa]

Description

Adds a minimum service constraint to the supply calculation, so it is consistent with the constraints used in the investment. This change only affects to the outputs of a couple of examples and tutorials - and only the MCAMetric-related outputs -, but none of the others, still producing the same outputs.

Fixes #335 , identified and further discussed in #321

Why there are two measures of supply instead of using the production calculated by the solver is another question and a matter for a different PR. After this PR is merged, both figures in #321 become the same, and equal to the one on the right.

Type of change

Please add a line in the relevant section of
CHANGELOG.md to
document the change (include PR #) - note reverse order of PR #s.

• New feature (non-breaking change which adds functionality)
• Optimization (non-breaking, back-end change that speeds up the code)
• Bug fix (non-breaking change which fixes an issue)
• Breaking change (whatever its nature)

Key checklist

• All tests pass: $ python -m pytest
• The documentation builds and looks OK: $ python -m sphinx -b html docs docs/build

Further checks

• Code is commented, particularly in hard-to-understand areas
• Tests added that prove fix is effective or that feature works

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.39%. Comparing base (5aeea97) to head (7b522aa).
Report is 430 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #368      +/-   ##
===========================================
+ Coverage    71.29%   71.39%   +0.10%     
===========================================
  Files           44       44              
  Lines         5880     5894      +14     
  Branches      1159     1162       +3     
===========================================
+ Hits          4192     4208      +16     
+ Misses        1366     1365       -1     
+ Partials       322      321       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[alexdewar]

Seems sensible!

[dalonsoa]

Not fixing the problem.

[tsmbland]

@dalonsoa I still think we should do this. There's no reason not to include the MSF in this function, and as discussed in #423, this function is being used to calculate supply even when using the scipy solver (except, as discussed in #474, when using dispatch_production = "costed")

Long run we'll want to use the outputs directly from the scipy solver rather than using this function, but while we're using this function it might as well do the correct thing