Conversation
dalonsoa
approved these changes
Nov 1, 2024
This was referenced Nov 20, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deletes the
legacy_sectormodule, and some other parts of the code that were only used by the legacy sector.Obviously this breaks backwards compatibility, but given how minimal the tests are (and they're not run as part of CI anyway), there's no guarantee that the legacy sector still works anyway.
This will just allow me to focus on the important parts of the code when making changes and not waste time fixing code that won't ever be used. If anyone still needs to use this, they will still have access to older version of MUSE
Obviously I'll bump the minor version once this is merged as it breaks backwards compatibility
Closes #509
Closes #358