forked from Dosugamea/NEXT-OCS-API-forPy
-
Notifications
You must be signed in to change notification settings - Fork 26
Notifications #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
matejak
merged 1 commit into
EnterpriseyIntranet:master
from
danil-topchiy:notifications
Jan 15, 2019
Merged
Notifications #16
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| from .base import BaseTestCase | ||
|
|
||
|
|
||
| class TestNotifications(BaseTestCase): | ||
|
|
||
| SUCCESS_CODE = 200 | ||
|
|
||
| def test_get_delete_notifications(self): | ||
| # get all notifications | ||
| res = self.nxc.get_notifications() | ||
| all_data = res['ocs']['data'] | ||
| assert res['ocs']['meta']['statuscode'] == self.SUCCESS_CODE | ||
|
|
||
| if len(all_data): | ||
| notification = all_data[0] | ||
|
|
||
| # get single notification | ||
| res = self.nxc.get_notification(notification['notification_id']) | ||
| assert res['ocs']['meta']['statuscode'] == self.SUCCESS_CODE | ||
| assert res['ocs']['data']['notification_id'] == notification['notification_id'] | ||
|
|
||
| # delete single notification | ||
| res = self.nxc.delete_notification(notification['notification_id']) | ||
| assert res['ocs']['meta']['statuscode'] == self.SUCCESS_CODE | ||
| else: | ||
| # assert get single notification will return 404 not found | ||
| res = self.nxc.get_notification(1) | ||
| assert res['ocs']['meta']['statuscode'] == self.NOT_FOUND_CODE | ||
|
|
||
| # delete all notifications success code check | ||
| res = self.nxc.delete_all_notifications() | ||
| assert res['ocs']['meta']['statuscode'] == self.SUCCESS_CODE | ||
|
|
||
| # TODO: add more tests if WebDAV api will be implemented and there will be ability to make actions | ||
| # using api which creates notifications (mentions in comments) | ||
| # or when Federated file sharings api will be implemented (harder way) | ||
|
|
||
|
|
||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is interesting, the test looks like that it may end up either way - there are or aren't any notifications. I would appreciate more control - what about deleting, asserting that there are none, and then adding and rediscovering them. Does it make sense?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, you right. As far as I researched, right now there is no possibility to create actions using api. It will be possible if we have WebDAV api implemented, which will let us make files related changes, writing comments, or Federated files sharing api, which also creates activity objects when sharing with another cloud. Also the same related to activites api (#15) tests.
Noticed it in code below as well:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!