Remove fullscreen button on iPad if using a non Safari browser by lukehb · Pull Request #334 · EpicGamesExt/PixelStreamingInfrastructure

lukehb · 2024-11-28T05:29:40Z

Relevant components:

Frontend UI library

Problem statement:

Using fullscreen video on iPad + touch interactions + non-Safari browsers = video gets dragged around the screen.

This is fairly unusable for Pixel Streaming but it browser defined behaviour that can't be disabled it seems.

Additionally if you leave fullscreen from one of these non-Safari browsers on the iPad the video stream will pause and cannot be resumed without re-entering fullscreen mode because we hide the video controls.

Solution

Don't allow fullscreen button on these non-Safari browsers on iPad.

Documentation

N/A

Test Plan and Compatibility

Test on iPad on Safari = button still shows up
Test on iPad on Chrome = button is gone

…browsers

Frontend/library/src/VideoPlayer/VideoPlayer.ts

SignallingWebServer/platform_scripts/bash/common.sh

SignallingWebServer/platform_scripts/cmd/common.bat

lukehb · 2024-11-28T05:48:04Z

Frontend/implementations/typescript/src/player.html


 <!-- The Pixel Streaming player fills 100% of its parent element but body has a 0px height unless filled with content. As such, we explicitly force the body to be 100% of the viewport height -->
-<body style="width: 100vw; height: 100svh; min-height: -webkit-fill-available; font-family: 'Montserrat'; margin: 0px">
+<body style="width: 100vw; height: 100svh; min-height: -webkit-fill-available; overflow: hidden; overscroll-behavior: none; font-family: 'Montserrat'; margin: 0px">


This removes scroll bounce zone on iPad that is unhelpful for Pixel Streaming

github-actions · 2024-11-29T00:10:32Z

💔 All backports failed

Status	Branch	Result
❌	UE5.4	Backport failed because of merge conflicts
❌	UE5.3	Backport failed because of merge conflicts
❌	UE5.2	Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

backport --pr 334

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Remove fullscreen button on iPad if using a non Safari browser (cherry picked from commit 3f10f01) # Conflicts: # Frontend/implementations/EpicGames/src/player.html # Frontend/ui-library/src/Application/Application.ts

Remove fullscreen button on iPad if using a non Safari browser (cherry picked from commit 3f10f01) # Conflicts: # Frontend/ui-library/src/Application/Application.ts

mcottontensor · 2024-11-29T01:38:28Z

💚 All backports created successfully

Status	Branch	Result
✅	UE5.2
✅	UE5.3
✅	UE5.4

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

[UE5.2] Merge pull request #334 from EpicGamesExt/issue219

[UE5.3] Merge pull request #334 from EpicGamesExt/issue219

[UE5.4] Merge pull request #334 from EpicGamesExt/issue219

lukehb added 4 commits November 26, 2024 10:52

Attempt to hide video player controls on iPad (it doesn't work)

9bfc87c

Added extra check to disable fullscreen button on iPad in non-safari …

b8bdf23

…browsers

Fixing linting issue

9506b41

Better Safari detection and removing overflow on iPad

b15f928

lukehb added auto-backport Used to specify we want a PR to auto backport to a branch, must be paired with auto-backport-to-UEX. auto-backport-to-UE5.4 Auto backport to UE 5.4 auto-backport-to-UE5.3 Auto backport to UE 5.3 auto-backport-to-UE5.2 Auto backport to UE 5.2 labels Nov 28, 2024

Merge branch 'UE5.5' into issue219

73329e3

lukehb removed auto-backport Used to specify we want a PR to auto backport to a branch, must be paired with auto-backport-to-UEX. auto-backport-to-UE5.4 Auto backport to UE 5.4 auto-backport-to-UE5.3 Auto backport to UE 5.3 auto-backport-to-UE5.2 Auto backport to UE 5.2 labels Nov 28, 2024