Fix: Chrome + iPad not creating rootElement early enough for custom frontends#410
Merged
mcottontensor merged 2 commits intomasterfrom Jan 19, 2025
Merged
Fix: Chrome + iPad not creating rootElement early enough for custom frontends#410mcottontensor merged 2 commits intomasterfrom
mcottontensor merged 2 commits intomasterfrom
Conversation
mcottontensor
approved these changes
Jan 19, 2025
Contributor
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
This was referenced Jan 19, 2025
Collaborator
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
mcottontensor
added a commit
that referenced
this pull request
Jan 19, 2025
[UE5.5] Merge pull request #410 from EpicGamesExt/fix-ipad-chrome
mcottontensor
added a commit
that referenced
this pull request
Jan 19, 2025
[UE5.3] Merge pull request #410 from EpicGamesExt/fix-ipad-chrome
mcottontensor
added a commit
that referenced
this pull request
Jan 19, 2025
[UE5.4] Merge pull request #410 from EpicGamesExt/fix-ipad-chrome
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relevant components:
Problem statement:
The
_rootElementin the Pixel Streaming UI library was not created explicitly, but rather created lazily by a getter calledrootElement. There were some scenarios where you could trigger internal code paths that used the_rootElementbefore any call had been made via the getter to initialize it. This would result in a JS error for those calling functions.Solution
This PR explicitly initializes the
_rootElementin the constructor of the Pixel StreamingApplication- this way the calling order is no longer important and it is always safe to access the_rootElement.Test Plan and Compatibility
I have tested this locally using my Chrome browser, but did not have an iPad nearby to confirm. I will get someone to test this downstream once it is landed to confirm the fix is valid.