Fix removing negative items in /clearinventory #5899
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Evidentsinger14
changed the title
JRoy
approved these changes
Aug 11, 2024
Euphillya
added a commit
to Euphillya/Essentials-Folia
that referenced
this pull request
Aug 13, 2024
EssentialsX@b763fd3 Fix removing negative items in /clearinventory (EssentialsX#5899) EssentialsX@7ae01a0 Update to Minecraft 1.21.1 (EssentialsX#5900) EssentialsX@f1a5caf Fixes wording on CannotRemoveNegativeItems (EssentialsX#5901)
Starmism
pushed a commit
to valence-smp/Essentials
that referenced
this pull request
Jan 8, 2025
Co-authored-by: JRoy <10731363+JRoy@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Information
This PR fixes #5894
Details
Proposed fix:
ensure amount of removed items is not less than -1 (-1 clears all items of that type)
Environments tested:
OS: Windows 10
Java version: 21.0.3
Demonstration:
before:
after:
