Skip to content

fix: Resolve integration test failures and enhance static binary export extraction #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
unclesp1d3r merged 4 commits into from
Nov 9, 2025
Merged

fix: Resolve integration test failures and enhance static binary export extraction #51

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f432f79
Initial plan
Copilot Nov 9, 2025
12f5bae
fix: CI test failures and improve ELF export extraction
Copilot Nov 9, 2025
399814e
Merge branch '1-implement-intelligent-elf-section-classification-for-…
unclesp1d3r Nov 9, 2025
9943114
perf: optimize export deduplication with HashSet (O(1) vs O(n))
Copilot Nov 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 33 additions & 6 deletions src/container/elf.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ use crate::types::{
};
use goblin::Object;
use goblin::elf::{Elf, SectionHeader};
use std::collections::HashSet;

/// Parser for ELF (Executable and Linkable Format) binaries
pub struct ElfParser;
Expand Down Expand Up @@ -163,19 +164,45 @@ impl ElfParser {
/// Extract basic export information from ELF symbol table
fn extract_exports(&self, elf: &Elf) -> Vec<ExportInfo> {
let mut exports = Vec::new();
let mut seen_names = HashSet::new();

// Extract from dynamic symbol table
for sym in &elf.dynsyms {
if sym.st_bind() == goblin::elf::sym::STB_GLOBAL
if (sym.st_bind() == goblin::elf::sym::STB_GLOBAL
|| sym.st_bind() == goblin::elf::sym::STB_WEAK)
&& sym.st_shndx != (goblin::elf::section_header::SHN_UNDEF as usize)
&& sym.st_value != 0
{
if let Some(name) = elf.dynstrtab.get_at(sym.st_name) {
exports.push(ExportInfo {
name: name.to_string(),
address: sym.st_value,
ordinal: None, // ELF doesn't use ordinals
});
if !name.is_empty() && seen_names.insert(name.to_string()) {
exports.push(ExportInfo {
name: name.to_string(),
address: sym.st_value,
ordinal: None, // ELF doesn't use ordinals
});
}
}
}
}

// Also check regular symbol table for static exports
for sym in &elf.syms {
if (sym.st_bind() == goblin::elf::sym::STB_GLOBAL
|| sym.st_bind() == goblin::elf::sym::STB_WEAK)
&& sym.st_shndx != (goblin::elf::section_header::SHN_UNDEF as usize)
&& sym.st_value != 0
&& (sym.st_type() == goblin::elf::sym::STT_FUNC
|| sym.st_type() == goblin::elf::sym::STT_OBJECT
|| sym.st_type() == goblin::elf::sym::STT_NOTYPE)
{
if let Some(name) = elf.strtab.get_at(sym.st_name) {
if !name.is_empty() && seen_names.insert(name.to_string()) {
exports.push(ExportInfo {
name: name.to_string(),
address: sym.st_value,
ordinal: None, // ELF doesn't use ordinals
});
}
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion tests/integration_elf.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ int main() {
.args(["-o", elf_file.to_str().unwrap(), c_file.to_str().unwrap()])
.output();

// If cross-compiler not available, try regular gcc
// If cross-compiler not available, try regular gcc (dynamically linked)
if output.is_err() {
output = Command::new("gcc")
.args(["-o", elf_file.to_str().unwrap(), c_file.to_str().unwrap()])
Expand Down