[HOLD for payment 2023-08-01] [HOLD for payment 2023-07-28] Room - Deleted message and broken avatar displayed in header for threaded reply in public room

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when executing PR #23098

Action Performed:

Prerequisite: user A created a public room

1. User A send a message to the public room
2. User A add a reply to the message to create a thread

Expected Result:

Message is displayed as header ( in this case Hello) and no broken avatar image

Actual Result:

Deleted message and broken avatar displayed as header

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.43.0
Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @stitesExpensify (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[mountiny]

@hannojg @0xmiroslav @fedirjh I think this might be related to the #21406

[b4s36t4]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Deleted message and broken avatar displayed in header for threaded reply in public room

What is the root cause of that problem?

RCA for this issue lies here on this block.

App/src/libs/ReportActionsUtils.js

Lines 103 to 108 in cc51a0d

	function getParentReportAction(report, allReportActionsParam = {}) {
	if (!report || !report.parentReportID || !report.parentReportActionID) {
	return {};
	}
	return lodashGet(allReportActionsParam || allReportActions, [report.parentReportID, report.parentReportActionID], {});
	}

If we observe the last line which we're using lodash to get particular report action but the items which we're getting is always gonna be empty.

{} || {"key":"value"}

will always be {} same happening here.

App/src/libs/ReportActionsUtils.js

Line 103 in cc51a0d

function getParentReportAction(report, allReportActionsParam = {}) {

We're defining empty object here which is always the case lodash search on.

Means we're basically checking for parent Report action on an empty object {} which is resulting the following issue.

What changes do you think we should make in order to solve the problem?

1. We can make allReportActionsParam as null or undefined.
2. We can use isEmpty function to determine on which object we're going to get parent report action.
3. We can pass parentReportActions from HeaderView component to here

   App/src/libs/ReportUtils.js

   Line 1122 in cc51a0d

   function getReportName(report) {

   and then pass it here

   App/src/libs/ReportUtils.js

   Line 1125 in cc51a0d

   const parentReportAction = ReportActionsUtils.getParentReportAction(report);

   so that everything works seamlessly.

What alternative solutions did you explore? (Optional)

NA

[0xmiroslav]

@hannojg @0xmiroslav @fedirjh I think this might be related to the #21406

yes, this is the bug I mentioned in #21406 (comment)

[jasperhuangg]

This appears to be a regression from @hannojg's PR #21406.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.