[HOLD for payment 2023-11-01] [HOLD for payment 2023-10-31] [$500] [HIGH] [P2P Activation] System message is showing in the chat preview in LHN

[kevinksullivan]

coming from https://expensify.slack.com/archives/C05RECHFBEW/p1697754930131319

and related to changes in #29430

The system message for needing to enable a wallet should only show on the IOU, and not in the DM as well (since the message doesn't show in the DM at all).

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c788d51e8ac49ab8
• Upwork Job ID: 1715150172239216640
• Last Price Increase: 2023-10-20
• Automatic offers:
• situchan | Reviewer | 27294351
• b4s36t4 | Contributor | 27294353

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[trjExpensify]

Interesting, yeah!

1. The last message in the DM is the report preview component of the iouReport with the title: "Money2020 paid $1.00"
2. The last action in the iouReport is: "started settling up, payment is held until Kevin adds a bank account."
3. For some reason the last action is being shown instead of the iouReport title

@kevinksullivan, so confirming when we fix this the two LHN rows will be as follows:

iouReport

Money2020 paid $1.00
started settling up, payment is held until %recipient firstName% enables the Expensify Wallet

DM

Kevin Sullivan
Money2020 paid $1.00

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01c788d51e8ac49ab8

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @jjcoffee (Internal)

[melvin-bot]

Current assignee @techievivek is eligible for the Engineering assigner, not assigning anyone new.

[kevinksullivan]

started settling up, payment is held until Kevin adds a bank account.

One correction on this one @trjExpensify , it's this copy:

started settling up, payment is held until %recipient firstName% enables the Expensify Wallet

The copy you see in the screenshot is a duplicate message / separate issue. See https://github.com/Expensify/Auth/pull/8973

Rest looks good to me.

[trjExpensify]

Perfect, fixed!