[Internal QA] Add enable wallet state button if the submitter hasn't completed the kyc by techievivek · Pull Request #29430 · Expensify/App

techievivek · 2023-10-12T12:11:49Z

Details

If there are queued reimbursements for the user and if they are on silver wallet then let's show an enable wallet button that will allow the user to add the wallet to receive the reimbursements.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/324579
PROPOSAL:

Tests

Login to newDot as a gold wallet user member.
Randomly send money to any other user who is on a silver wallet.
Confirm that you are able to send the money without any issue and the chat report, IOU report and transaction report are all created and rendered correctly.
Login to newDot as silver wallet user and go to the chat report with gold wallet user.
Confirm you can see a preview of the IOU report.
Click on it and it will take you to the IOU report where you can see the enable wallet button.
Confirm the IOU action preview is rendered correctly.
Click on enable wallet button and it should open the enable-payment page.

Verify that no errors appear in the JS console

Offline tests

QA Steps

Same as tests.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

MacOS: Chrome / Safari

Screen.Recording.2023-10-17.at.10.52.27.PM.mov

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Desktop

cloudflare-workers-and-pages · 2023-10-12T12:14:56Z

Deploying with Cloudflare Pages

Latest commit:	`3fdc0df`
Status:	✅ Deploy successful!
Preview URL:	https://6478cbcd.helpdot.pages.dev
Branch Preview URL:	https://techievivek-add-waiting-wall.helpdot.pages.dev

View logs

melvin-bot · 2023-10-17T17:23:06Z

@fedirjh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

MariaHCD

Looks good so far! Some minor comments.

@fedirjh, we'd appreciate a code review from you as well. This one is critical for an upcoming conference.

I can handle testing on all platforms since this requires a Gold wallet.

src/languages/en.ts

src/pages/home/report/ReportActionItem.js

fedirjh

The code looks good, but it still should be tested. Is there a beta for the gold wallet?

src/pages/home/report/ReportActionItem.js

MariaHCD · 2023-10-18T11:55:19Z

@techievivek can you also merge main into this branch?

MariaHCD · 2023-10-18T11:56:04Z

but it still should be tested. Is there a beta for the gold wallet?

I'm testing now. Everyone is on the wallet beta (with a silver wallet) but we do not have the ability to create test gold wallets at the moment.

MariaHCD · 2023-10-18T12:00:22Z

@techievivek I notice that the send money flow keeps redirecting the payer to the KYC flow even if the payer's wallet is activated:

Screen.Recording.2023-10-18.at.3.58.17.PM.mov

…ng_wallet_state

MariaHCD

Noticed a few things:

We need to direct the user to add a PBA first if they don't have one, this logic is handled by the KYCWall component, I think we should be able to use it here.
I'm seeing the report action twice and with incorrect messaging:

Payer with gold wallet sees this:

Payee with silver wallet sees this:

src/pages/home/report/ReportActionItem.js

…ng_wallet_state

MariaHCD · 2023-10-18T13:03:24Z

In the interest of saving time, I've DRY'd some code and added the use of the KYCWall

MariaHCD · 2023-10-18T13:04:15Z

We still need to:

Figure out why the queued action is being displayed twice
Figure out why a payer can't get past the KYC flow when sending money

MariaHCD · 2023-10-18T13:13:50Z

Okay, fixed the incorrect message for the payer:

But the action is still showing twice...

techievivek · 2023-10-18T13:32:30Z

src/pages/home/report/ReportActionItem.js

-                    ) : null}
+                    )}
+                    {shouldShowEnableWalletButton && (
+                        <KYCWall


I believe there may be a console error due to using KYCWall in ReportActionItemBasicMessage. IIRC that was the case when I attempted the same change.

Are you referring to this error? I think wrapping the button inside a fragment should fix this warning. I will suggest the changes.

Testing it, thanks.

That worked 🎉, but I am curious to learn how it fixed that error? Because there is just a single element right? KYCWall so why do we need a fragment here?

As ReportActionItemBasicMessage expects only one element, it is necessary to wrap both the "Add Bank" button and the KYCWall with a fragment. Without this fragment, React will treat both elements (the first button and the KYCWall) as an array. It's important to note that even if the { bool && <Component /> } condition evaluates to false, it will still be passed to the parent component as a false value. So, in our case, it's passed as [false, KYCWall]. By wrapping them in a single fragment, it ensures that they are always passed as a single element.

Interesting, but by just wrapping the KycWall in a fragment it looks like the error is gone, how does that work? Any idea?

Ah no, the user is alreadt on the gold wallet that's why this condition is not being called.

The error is still there. What you explained make sense now. Thanks 👍

fedirjh

The code looks good. I just tested some hardcoded values and it seems to be working fine

CleanShot.2023-10-18.at.18.13.08-converted.mp4

src/pages/home/report/ReportActionItem.js

fedirjh · 2023-10-18T17:21:53Z

src/pages/home/report/ReportActionItem.js

-                    ) : null}
+                    )}
+                    {shouldShowEnableWalletButton && (
+                        <KYCWall


Are you referring to this error? I think wrapping the button inside a fragment should fix this warning. I will suggest the changes.

MariaHCD · 2023-10-19T08:10:53Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-10-19.at.11.46.58.AM.mov

Screen.Recording.2023-10-19.at.11.54.57.AM.mov

Mobile Web - Chrome

Screen.Recording.2023-10-19.at.11.56.57.AM.mov

Mobile Web - Safari

Screen.Recording.2023-10-19.at.12.06.15.PM.mov

Desktop

Screen.Recording.2023-10-19.at.11.55.35.AM.mov

iOS

Screen.Recording.2023-10-19.at.12.08.33.PM.mov

Android

Screen.Recording.2023-10-19.at.12.51.13.PM.mov

MariaHCD · 2023-10-19T08:54:01Z

LGTM, we're going to address polish items in follow up PRs. Please final review, @fedirjh 🙏🏼

fedirjh

Looks good to me, just one little change and should be ready to get merged.

fedirjh · 2023-10-19T12:54:44Z

src/pages/home/report/ReportActionItem.js

                        />
-                    ) : null}
+                    )}
+                    <>


This fragment should wrap both elements, the button and the KYCWall.

fedirjh

Looks good to me.

melvin-bot · 2023-10-19T13:20:23Z

@thienlnam Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2023-10-19T13:20:27Z

🎯 @fedirjh, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #29973.

OSBotify · 2023-10-19T13:27:12Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-10-20T21:38:57Z

🚀 Deployed to staging by https://github.com/MariaHCD in version: 1.3.88-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-23T04:51:09Z

🚀 Deployed to production by https://github.com/chiragsalian in version: 1.3.88-11 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

cead22 · 2023-10-24T18:19:45Z

src/languages/es.ts

            duplicateWaypointsErrorMessage: 'Por favor elimina los puntos de ruta duplicados',
            emptyWaypointsErrorMessage: 'Por favor introduce al menos dos puntos de ruta',
        },
+        waitingOnEnabledWallet: ({submitterDisplayName}: WaitingOnBankAccountParams) => `nicio el pago, pero no se procesará hasta que ${submitterDisplayName} active su Billetera`,


@techievivek this should be Inició or inició, can you submit a PR to update please?

@cead22 Added here: #30335

added enable wallet state

67077a8

techievivek self-assigned this Oct 12, 2023

techievivek changed the title ~~added enable wallet state~~ Add enable wallet state button if the submitter hasn't completed the kyc Oct 12, 2023

techievivek added 3 commits October 16, 2023 12:34

added enable wallet state

d4a4d7b

Merge branch 'main' into techievivek_add_waiting_wallet_state

c71eedf

continue testing

56b0a7c

techievivek marked this pull request as ready for review October 17, 2023 17:23

techievivek requested a review from a team as a code owner October 17, 2023 17:23

melvin-bot bot requested review from fedirjh and removed request for a team October 17, 2023 17:23

techievivek requested a review from MariaHCD October 17, 2023 17:36

MariaHCD reviewed Oct 18, 2023

View reviewed changes

src/languages/en.ts Outdated Show resolved Hide resolved

src/pages/home/report/ReportActionItem.js Outdated Show resolved Hide resolved

fedirjh reviewed Oct 18, 2023

View reviewed changes

src/pages/home/report/ReportActionItem.js Outdated Show resolved Hide resolved

Merge remote-tracking branch 'origin/main' into techievivek_add_waiti…

419c505

…ng_wallet_state

MariaHCD requested changes Oct 18, 2023

View reviewed changes

src/pages/home/report/ReportActionItem.js Outdated Show resolved Hide resolved

MariaHCD added 3 commits October 18, 2023 16:58

Merge remote-tracking branch 'origin/main' into techievivek_add_waiti…

be8a67d

…ng_wallet_state

DRY logic and check for silver wallet

8eb2447

Use the KYCWall

88e4ca4

MariaHCD added 2 commits October 18, 2023 17:11

Show correct messaging to payer

02f96fa

Rename translation prop

a4153eb

Default value for userWallet

9b863ab

techievivek commented Oct 18, 2023

View reviewed changes

techievivek changed the title ~~Add enable wallet state button if the submitter hasn't completed the kyc~~ [Internal QA] Add enable wallet state button if the submitter hasn't completed the kyc Oct 18, 2023

fedirjh reviewed Oct 18, 2023

View reviewed changes

fix the console error

9eb037b

techievivek requested a review from fedirjh October 19, 2023 05:52

MariaHCD previously approved these changes Oct 19, 2023

View reviewed changes

fedirjh reviewed Oct 19, 2023

View reviewed changes

add everything in fragment

3fdc0df

techievivek dismissed MariaHCD’s stale review via 3fdc0df October 19, 2023 13:06

techievivek requested a review from fedirjh October 19, 2023 13:06

MariaHCD approved these changes Oct 19, 2023

View reviewed changes

fedirjh approved these changes Oct 19, 2023

View reviewed changes

melvin-bot bot requested a review from thienlnam October 19, 2023 13:20

melvin-bot bot mentioned this pull request Oct 19, 2023

Payment issue for E/App PR#29430 #29973

Closed

MariaHCD merged commit 9b032d2 into main Oct 19, 2023

MariaHCD deleted the techievivek_add_waiting_wallet_state branch October 19, 2023 13:21

OSBotify mentioned this pull request Oct 20, 2023

Deploy Checklist: New Expensify 2023-10-20 #30108

Closed

cead22 reviewed Oct 24, 2023

View reviewed changes

techievivek mentioned this pull request Oct 25, 2023

[NO QA]Fix the translation #30335

Merged

57 tasks

Conversation

techievivek commented Oct 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

cloudflare-workers-and-pages bot commented Oct 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying with Cloudflare Pages

Uh oh!

melvin-bot bot commented Oct 17, 2023

Uh oh!

MariaHCD left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

fedirjh left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

MariaHCD commented Oct 18, 2023

Uh oh!

MariaHCD commented Oct 18, 2023

Uh oh!

MariaHCD commented Oct 18, 2023

Uh oh!

MariaHCD left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

MariaHCD commented Oct 18, 2023

Uh oh!

MariaHCD commented Oct 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MariaHCD commented Oct 18, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

techievivek Oct 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

techievivek Oct 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fedirjh left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MariaHCD commented Oct 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

MariaHCD commented Oct 19, 2023

Uh oh!

fedirjh left a comment

Choose a reason for hiding this comment

Uh oh!

techievivek commented Oct 12, 2023 •

edited

Loading

cloudflare-workers-and-pages bot commented Oct 12, 2023 •

edited

Loading

MariaHCD commented Oct 18, 2023 •

edited

Loading

techievivek Oct 19, 2023 •

edited

Loading

techievivek Oct 19, 2023 •

edited

Loading

MariaHCD commented Oct 19, 2023 •

edited

Loading