[HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] Context Menu and hover menu is visible on message being Edited

[parasharrajat]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open any conversation on E.cash
2. Click Edit message from the context menu on any message.
3. Now right click on the message being edited or hover over it.

Expected Result:

Context & hover menu is not visible on the already edited message.

Actual Result:

Context menu & hover menu is visible on the message being edited.

Workaround:

None It. It is unexpected behavior. For eg., you can delete a message being edited.

Platform:

Where is this issue occurring?

Web - ✔️
iOS - ✔️
Android - ✔️
Desktop App - ✔️
Mobile Web - ✔️

Version Number: 1.0.71-0
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

menu-issue.mp4

Expensify/Expensify Issue URL:

View all open jobs on Upwork

[MelvinBot]

Triggered auto assignment to @alexpensify (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[parasharrajat]

Proposal

We need to block the context menu by adding a condition here https://github.com/Expensify/Expensify.cash/blob/baba3b9c129f054b3adc92579f6f270854832edb/src/pages/home/report/ReportActionItem.js#L167

    if (this.props.draftMessage) {
            return;
        }

then to block the hover menu here https://github.com/Expensify/Expensify.cash/blob/baba3b9c129f054b3adc92579f6f270854832edb/src/pages/home/report/ReportActionItem.js#L261

 isVisible={ hovered  && !this.state.isPopoverVisible && !this.props.draftMessage }

[MelvinBot]

Triggered auto assignment to @bondydaa (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[MelvinBot]

Triggered auto assignment to @jboniface (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.