Skip to content

chg: Block context menu on message being edited#3685

Merged
Dal-Papa merged 1 commit intoExpensify:mainfrom
parasharrajat:menu-edited
Jun 21, 2021
Merged

chg: Block context menu on message being edited#3685
Dal-Papa merged 1 commit intoExpensify:mainfrom
parasharrajat:menu-edited

Conversation

@parasharrajat
Copy link
Copy Markdown
Member

Details

If the message is being edited, we check for the draft message on that message Item and if there is a draft, we block the context menu from showing up.

Fixed Issues

Fixes #3677

Tests | QA Steps

  1. Open any conversation on E.cash.
  2. Click Edit message from the context menu on any message.
  3. When the Edit box is visible. try to open the context menu on the message being edited.
  4. menu should not open.
  5. repeat all the above steps on each platfrom.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

w.mp4

Mobile Web

Desktop

d.mp4

iOS

Android

a.mp4

@parasharrajat parasharrajat requested a review from a team as a code owner June 18, 2021 21:19
@MelvinBot MelvinBot requested review from Dal-Papa and removed request for a team June 18, 2021 21:20
@Dal-Papa Dal-Papa merged commit c10f9e9 into Expensify:main Jun 21, 2021
@OSBotify
Copy link
Copy Markdown
Contributor

🚀 Deployed to staging in version: 1.0.72-3🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Copy Markdown
Contributor

🚀 Deployed to production in version: 1.0.73-3🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@parasharrajat parasharrajat deleted the menu-edited branch November 4, 2022 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] Context Menu and hover menu is visible on message being Edited

3 participants