-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Closed
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionAuto-added when associated PR is deployed to productionDailyKSv2KSv2ExternalAdded to denote the issue can be worked on by a contributorAdded to denote the issue can be worked on by a contributorNewFeatureSomething to build that is a new item.Something to build that is a new item.
Description
Tracking issue: https://github.com/Expensify/Expensify/issues/393839
This issue is the NewDot part of https://github.com/Expensify/Expensify/issues/404210
Action Performed:
- Create Control workspace, make sure you can see it in NewDot
- In OldDot, make sure the Control workspace has "Advanced Approvals" set up (on the workspace settings -> Members tab)
- In OldDot, Add at least 2 other members (non-admin)
- In OldDot, Set up 1 of the members (Member A) as the
submitsToof the other member (Member B) - In NewDot, as the admin, try to remove
Member Afrom the workspace
Expected Result:
- Check if the person being removed exists in the policy's
employeeListas an approver (listed as any member's submitsTo, forwardsTo, or overLimitForwardsTo)- If YES, show the user a warning & set some optimistic data before calling
DeleteMembersFromWorkspace:- Warning copy should read:
Remove selected member?
[Selected member] is an approver in this workspace. When you remove them, we’ll replace them in the approval workflow with the workspace owner, [Workspace Owner].
- Warning copy should read:
- If YES, show the user a warning & set some optimistic data before calling
- Optimistically also replace the removed person w/ the workspace owner, anywhere they existed in the policy
employeeListas an approver
3. If NO, proceed as normal withDeleteMembersFromWorkspace
Note: Backend Onyx updates will happen in https://github.com/Expensify/Expensify/issues/404210
Also note: In #43508 we're implementing the ability for non-owner admins to leave workspaces so that doesn't need to be handled in this issue
cc @garrettmknight in case you'd like to be involved in this change
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01bf9c32f16606de5d
- Upwork Job ID: 1802955325447394518
- Last Price Increase: 2024-06-18
- Automatic offers:
- akinwale | Reviewer | 102790397
- nkdengineer | Contributor | 102790399
Issue Owner
Current Issue Owner: @trjExpensifyReactions are currently unavailable
Metadata
Metadata
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionAuto-added when associated PR is deployed to productionDailyKSv2KSv2ExternalAdded to denote the issue can be worked on by a contributorAdded to denote the issue can be worked on by a contributorNewFeatureSomething to build that is a new item.Something to build that is a new item.
Type
Projects
Status
Done