Report fields - List value disappears after deleting offline

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.6-0
Reproducible in staging?: Y
Reproducible in production?: Y
Found when validating PR : #44730
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. Navigate to staging.new.expensify.com
2. Create a workspace
3. Go to workspace editor > more features > enable report fields
4. Add a new List type report field
5. Add a list value
6. Go offline
7. Delete the list value

Expected Result:

While offline the deleted list value should be crossed

Actual Result:

The deleted list value disappears even if app is while offline

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6537999_1720623214336.bandicam_2024-07-10_17-32-59-463.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[izarutskaya]

We think this issue might be related to the #wave-control

[devguest07]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Report fields - List value disappears after deleting offline

What is the root cause of that problem?

The condition to show the empty state exclude the fields where there's a pending action equal to delete. This means this reportField (and any others with pendingAction: "delete") would be filtered out.
If all items in filteredPolicyFieldList have pendingAction: "delete", then after filtering, the resulting array would have a length of 0.

Therefore, shouldShowEmptyState would be true if:

1. All items in filteredPolicyFieldList have pendingAction: "delete", causing the filtered array to have a length of 0.
2. AND isLoading is false.

App/src/pages/workspace/reportFields/WorkspaceReportFieldsPage.tsx

Line 130 in 8978256

const shouldShowEmptyState =

What changes do you think we should make in order to solve the problem?

If we want to show the empty state only when there are no fields at all, regardless of their pendingAction:

const shouldShowEmptyState = Object.values(filteredPolicyFieldList).length === 0 && !isLoading;

What alternative solutions did you explore?

We can consider using hasVisibleCategories as we do for the other lists. Then adjust the WorkspaceEmptyStateSection display condition

App/src/pages/workspace/categories/WorkspaceCategoriesPage.tsx

Line 260 in 7bed113

const hasVisibleCategories = categoryList.some((category) => category.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE || isOffline);

[mountiny]

@waterim @rezkiy37 who can take this one?

[sakluger]

Bump @waterim @rezkiy37